Improve Flutter and Dart SDK using official lint rules #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wess
reviewed
Feb 22, 2022
| @@ -38,9 +38,9 @@ class {{ service.name | caseUcfirst }} extends Service { | |||
| }; | |||
|
|
|||
| {% if method.type == 'location' %} | |||
| params.keys.forEach((key) {if (params[key] is int || params[key] is double) { | |||
| for(var key in params.keys) {if (params[key] is int || params[key] is double) { | |||
There was a problem hiding this comment.
Why a for loop when you could use filter/map/reduce? (Map is faster and resource efficient).
There was a problem hiding this comment.
removed, as I think this was a leftover
| @@ -40,15 +40,15 @@ class ClientMixin { | |||
| } else if (method == HttpMethod.get) { | |||
| final encoded = <String, dynamic>{}; | |||
| if (params.isNotEmpty) { | |||
| params.keys.forEach((key) { | |||
| for(var key in params.keys) { | |||
There was a problem hiding this comment.
Why a for loop when you could use a map? (Map is faster and resource efficient).
| params.keys.forEach((key) {if (params[key] is int || params[key] is double) { | ||
| params[key] = params[key].toString(); | ||
| }}); | ||
| for (var key in params.keys) { |
There was a problem hiding this comment.
Suggest using a map/filter here
There was a problem hiding this comment.
removed, as I think this was a leftover
| message.channels.forEach((channel) { | ||
| if (this._channels[channel] != null) { | ||
| this._channels[channel]!.forEach((stream) { | ||
| for(var channel in message.channels) { |
There was a problem hiding this comment.
since dealing with sinks, for loop looks good here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.