web - add index type to Models that have additionalProperties set to … #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…true
Current behavior
In the web SDK typings,
Preferences
is atype Preferences = {}
which makes it tricky to work with in projects with TypeScript strict mode on.Expected behavior
type Preferences
should be an indexable type or a Record.This PR adds an indexable record to a model under
namespace Models
if its definition hasadditionalProperties: true
Additional information
I'm not sure how to verify the change with the current tests setup of this repo. Any suggestions would be much appreciated