Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor go templates #490

Merged
merged 1 commit into from
Jul 27, 2022
Merged

feat: refactor go templates #490

merged 1 commit into from
Jul 27, 2022

Conversation

everly-gif
Copy link
Contributor

refactor go templates

lohanidamodar
lohanidamodar approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should figure out a way to extract the upload script from client to file.twig may be after chunked upload implementation

@lohanidamodar lohanidamodar merged commit 3aa6d1d into master Jul 27, 2022
@lohanidamodar lohanidamodar deleted the feat-refactor-go-templates branch July 27, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@lohanidamodar lohanidamodar lohanidamodar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@everly-gif @lohanidamodar @Meldiron