Ensure node file upload captures and throws errors #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stream.write() must handle errors or else undefined behavior may occur. See https://nodejs.org/api/stream.html\#errors-while-writing for more info.
lohanidamodar
approved these changes
Dec 29, 2022
Meldiron
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
stream.write()must handle errors or else undefined behavior may occur. See https://nodejs.org/api/stream.html\#errors-while-writing for more info.Test Plan
Manually tested by uploading a file bigger than 5MB and less than 5MB
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes