Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new query operators #632

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Add new query operators #632

merged 4 commits into from
Apr 4, 2023

Conversation

abnegate
Copy link
Contributor

What does this PR do?

Add query support for:

  • isNull
  • isNotNull
  • between
  • startsWith
  • endsWith
  • select

Test Plan

Updated query tests

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Yes

@lohanidamodar lohanidamodar self-requested a review March 25, 2023 23:58
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


fun between(attribute: String, start: Double, end: Double) = Query.addQuery(attribute, "between", listOf(start, end))

fun between(attribute: String, start: String, end: String) = Query.addQuery(attribute, "between", listOf(start, end))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does between with string work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the letters like a numerical value, e.g. B is between A and C. Similarly, Boat is between Apple and Cat.

If multiple letters match it will check the following letter. E.g. Boat is between Bat and Cat.

@lohanidamodar lohanidamodar merged commit af96e57 into master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants