Fix node types #650
Merged
Fix node types #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may need to include dom in their tsconfig.json if they run into errors with Blob not found
Delete methods return empty string so the type should be a string. getAttribute() returns any one of the possible attributes so we'll use any for now. In the future, we can look into supporting a union type.
christyjacob4
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Delete methods return empty string so the type should be a string.
getAttribute() returns any one of the possible attributes so we'll use
any for now. In the future, we can look into supporting a union type.
Fix missing buffer type error
Fix missing NodeJS type
Test Plan
delete method:
getAttribute():
fix buffer and nodejs type errors:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes