Add inline doc comments to the Dart and Flutter SDKs #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2023
lohanidamodar
requested changes
Jun 18, 2023
| return 'write("$role")'; | ||
| } | ||
|
|
||
| /// Update permission for provided [role] |
There was a problem hiding this comment.
Suggested change
| /// Update permission for provided [role] | |
| /// Create permission for provided [role] |
There was a problem hiding this comment.
@lohanidamodar, I've fixed this typo.
Comment on lines
+9
to
+10
| /// [value] can be a single value or a list. If a list is used | ||
| /// the query will return resources where [attribute] is equal |
There was a problem hiding this comment.
this part is suitable for many other filters, let's update all relevant
There was a problem hiding this comment.
You mean for the other sdks? You want me to add it for all of them now? Would it be quicker to get this in first and then work on the other soon after?
There was a problem hiding this comment.
I mean for other methods in this query file
stnguyen90
force-pushed
the
feat-flutter-dart-docs
branch
from
121af7a to
b8a91f1
Compare
lohanidamodar
approved these changes
Jun 21, 2023
18 tasks
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add docs that will appear in IDEs and on pub.dev.
Test Plan
Manually generated SDKs:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes