Update flutter_web_auth_2 to stable 3.0.0 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThexXTURBOXx
commented
Oct 8, 2023
| @@ -13,15 +13,15 @@ platforms: | |||
| web: | |||
| windows: | |||
| environment: | |||
| sdk: '>=2.17.0 <3.0.0' | |||
| sdk: '>=2.17.0 <4.0.0' | |||
There was a problem hiding this comment.
If you want me to revert this change and also the http constraints change, please let me know and I will remove these from this PR.
ThexXTURBOXx
changed the title
1 task
|
@ThexXTURBOXx hey thanks for the PR, can you please sync with Master as we have new tests setup. Thank you. |
|
@lohanidamodar Thanks for reminding me! I have updated my branch properly and am waiting for the CI tests to finish. |
lohanidamodar
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR mainly updates
flutter_web_auth_2to the new stable version3.0.0.Also, the Flutter SDK and
httpconstraints have been loosened a bit.Another related issue with the current version: ThexXTURBOXx/flutter_web_auth_2#80
Test Plan
The migration guide describes all the necessary changes which have been applied here.
Related PRs and Issues
Partly relates to appwrite/sdk-for-flutter#96 since at least the authentication page can now be customised (in theory... No bindings have yet been added to the appwrite code to accomplish this)
Fixes #731
Have you read the Contributing Guidelines on issues?
Yes