-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ssr #725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, any insight into the CLI test failures? Looks like they were passing previously but I see you haven't any of the templates there 🤔
Seems like something related to the https://qa.appwrite.org/v1 server it's testing against. I had a go at fixing and then migrating to undici in CLI, but it's quite a bit of work so can raise a separate PR to avoid blocking SSR. |
@loks0n why are we using qa.appwrite.org ? Didn't we already move all the tests to SDK generator itself? Can you check? |
@loks0n Also, I switched the base branch, make sure you sync with this branch. |
It's hardcoded here:
|
Updated |
This reverts commit 5a33054.
What does this PR do?
form-data
andaxios
withundici
.Have you read the Contributing Guidelines on issues?
Yes