Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssr #725

Merged
merged 32 commits into from
Jan 19, 2024
Merged

feat: ssr #725

merged 32 commits into from
Jan 19, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Oct 11, 2023

What does this PR do?

  • Replaces node dependencies form-data and axios with undici.
  • Drops support for Node 14 and adds Node 20

Have you read the Contributing Guidelines on issues?

Yes

@loks0n loks0n requested review from abnegate, stnguyen90 and lohanidamodar and removed request for stnguyen90 December 14, 2023 18:13
Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, any insight into the CLI test failures? Looks like they were passing previously but I see you haven't any of the templates there 🤔

@loks0n
Copy link
Member Author

loks0n commented Dec 15, 2023

Looks good, any insight into the CLI test failures? Looks like they were passing previously but I see you haven't any of the templates there 🤔

Seems like something related to the https://qa.appwrite.org/v1 server it's testing against. I had a go at fixing and then migrating to undici in CLI, but it's quite a bit of work so can raise a separate PR to avoid blocking SSR.

@lohanidamodar
Copy link
Member

@loks0n why are we using qa.appwrite.org ? Didn't we already move all the tests to SDK generator itself? Can you check?

@lohanidamodar lohanidamodar changed the base branch from master to 1.5.x December 17, 2023 00:20
@lohanidamodar
Copy link
Member

@loks0n Also, I switched the base branch, make sure you sync with this branch.

@loks0n
Copy link
Member Author

loks0n commented Dec 19, 2023

@loks0n why are we using qa.appwrite.org ? Didn't we already move all the tests to SDK generator itself? Can you check?

It's hardcoded here:

execSync("node index client --endpoint 'https://qa.appwrite.org/v1' --projectId console --key=35y3h5h345 --selfSigned true", { stdio: 'inherit' });

@loks0n
Copy link
Member Author

loks0n commented Dec 19, 2023

@loks0n Also, I switched the base branch, make sure you sync with this branch.

Updated

@abnegate abnegate merged commit 4bece60 into 1.5.x Jan 19, 2024
36 checks passed
@abnegate abnegate deleted the feat-ssr branch January 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants