Feat android messaging #763
Conversation
# Conflicts: # .github/workflows/tests.yml
| @@ -318,79 +348,13 @@ public function getFiles(): array | |||
| ], | |||
| [ | |||
| 'scope' => 'copy', | |||
| 'destination' => '/example/.gitignore', | |||
There was a problem hiding this comment.
are we removing these example files?
There was a problem hiding this comment.
Just for the Java specific example, they are only used for dev testing while adding new features, and I never use the Java one
templates/android/build.gradle.twig
Outdated
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | ||
| classpath 'io.github.gradle-nexus:publish-plugin:1.1.0' | ||
| classpath 'io.github.gradle-nexus:publish-plugin:1.3.0' | ||
| classpath 'com.google.gms:google-services:4.4.0' |
There was a problem hiding this comment.
I'm not comfortable with adding this by default, isn't there a way to avoid this and allow user to add it in their app build.gradle file instead of adding in the SDK? Doing this will complicate Flutter as we will have to add and maintain Firebase library for all Flutter platforms
There was a problem hiding this comment.
Yep removed this, it's redundant as users have to add it to their gradle build anyway. We will still need to add the Firebase BOM + messaging library as a dependency to the SDK though
What does this PR do?
Add Android push notification handling
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)