-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exports enums js #774
Conversation
@loks0n Lets keep the TS enums:
The breaking change is okay for SDKs, this will be the case for all typed languages, since we now expect the enum type instead of a string
Node can continue using plain objects instead of TS enums
If this is a convention we are using elsewhere let's do it, otherwise in my experience they should be pascal case |
Not a fan of this DX personally but OK
OK
Both are acceptable just personally preferred UPPER_SNAKE, reverted. |
Object.freeze
for node