Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node and web checks to be case insensitive #776

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

Make sure if we create a tag with lowercase -rc, it's still published as a pre-release

Test Plan

image

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loks0n
Copy link
Member

loks0n commented Mar 19, 2024

@stnguyen90 should this be targeting master now?

@stnguyen90 stnguyen90 changed the base branch from 1.5.x to master March 19, 2024 21:43
@lohanidamodar lohanidamodar merged commit 133e1b1 into master Mar 20, 2024
34 checks passed
@lohanidamodar lohanidamodar deleted the fix-web-node-travis branch March 20, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants