-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vision os and fix warnings & errors #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Couple of small comments
Have you had a chance to give this a test on a physical device? Or simulator if not |
I haven't tested it at the moment. I did only test if it would compile and it succeed on all apple platforms (haven't tested linux or windows) for both swift-server and apple sdk. I don't think I have much time today, so if you want me to test it, I can do it tomorrow. Or you can test it yourself today. |
Tomorrow is fine, excited to hear how it goes 😄 |
I have tested it now on all apple platforms (not on windows or linux) |
Is there another problem with this mr? |
@svenopdehipt Please sync with the main branch to resolve the conflicts |
I have removed the conflicts, but I haven't tested it again. Can do so tomorrow. |
@abnegate I have tested it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work
Add support for visionOS and arm64 simulator
Fix warnings:
Fix error: WebAuthComponents was missing for swift-server target