Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vision os and fix warnings & errors #777

Merged
merged 4 commits into from
Mar 10, 2024
Merged

Add support for vision os and fix warnings & errors #777

merged 4 commits into from
Mar 10, 2024

Conversation

svenopdehipt
Copy link

Add support for visionOS and arm64 simulator

Fix warnings:

  1. use singleton instead of createNew
  2. explicit ignore unused result
  3. warning regarding sendable function closure

Fix error: WebAuthComponents was missing for swift-server target

Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Couple of small comments

src/SDK/Language/Swift.php Outdated Show resolved Hide resolved
@abnegate
Copy link
Contributor

Have you had a chance to give this a test on a physical device? Or simulator if not

@svenopdehipt
Copy link
Author

svenopdehipt commented Feb 25, 2024

I haven't tested it at the moment. I did only test if it would compile and it succeed on all apple platforms (haven't tested linux or windows) for both swift-server and apple sdk. I don't think I have much time today, so if you want me to test it, I can do it tomorrow. Or you can test it yourself today.

@abnegate
Copy link
Contributor

I haven't tested it at the moment. I did only test if it would compile and it succeed on all apple platforms (haven't tested linux or windows) for both swift-server and apple sdk. I don't think I have much time today, so if you want me to test it, I can do it tomorrow. Or you can test it yourself today.

Tomorrow is fine, excited to hear how it goes 😄

@svenopdehipt
Copy link
Author

I haven't tested it at the moment. I did only test if it would compile and it succeed on all apple platforms (haven't tested linux or windows) for both swift-server and apple sdk. I don't think I have much time today, so if you want me to test it, I can do it tomorrow. Or you can test it yourself today.

Tomorrow is fine, excited to hear how it goes 😄

I have tested it now on all apple platforms (not on windows or linux)

@svenopdehipt
Copy link
Author

Is there another problem with this mr?

@abnegate
Copy link
Contributor

abnegate commented Mar 8, 2024

@svenopdehipt Please sync with the main branch to resolve the conflicts

@svenopdehipt
Copy link
Author

@svenopdehipt Please sync with the main branch to resolve the conflicts

I have removed the conflicts, but I haven't tested it again. Can do so tomorrow.

@svenopdehipt
Copy link
Author

@abnegate I have tested it now

Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work

@abnegate abnegate merged commit 51912b3 into appwrite:master Mar 10, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants