Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apple realtime with multiple subscriptions #830

Merged
merged 8 commits into from
May 17, 2024

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented May 10, 2024

@stnguyen90 stnguyen90 self-requested a review May 10, 2024 05:30
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A contributor tested something like this and the error that this was supposed to prevent came back:

NIOCore/EventLoop.swift:1168: Fatal error: BUG DETECTED: syncShutdownGracefully() must not be called when on an EventLoop.
Calling syncShutdownGracefully() on any EventLoop can lead to deadlocks.
Current eventLoop: SelectableEventLoop { selector = Selector { descriptor = 5 }, thread = NIOThread(name = NIO-ELT-0-#0) }

@abnegate abnegate requested a review from stnguyen90 May 15, 2024 07:22
@stnguyen90 stnguyen90 requested a review from lohanidamodar May 16, 2024 00:59
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get multiple events through 🎉

@abnegate abnegate merged commit 830a46c into master May 17, 2024
34 checks passed
@abnegate abnegate deleted the fix-apple-multiple-subscriptions branch May 17, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants