Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enum Casings For Swift & Dart #885

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Jun 19, 2024

What does this PR do?

Enums in Swift & Dart should be in a lowerCamelCase.

Test Plan

N/A.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes.

@lohanidamodar lohanidamodar requested a review from abnegate July 8, 2024 02:47
src/SDK/Language.php Outdated Show resolved Hide resolved
@ItzNotABug ItzNotABug requested a review from abnegate July 8, 2024 07:25
Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a value to the mock enum endpoint with all upper case and test against it to make sure the templating is correct for all languages

@ItzNotABug ItzNotABug requested a review from abnegate October 7, 2024 08:10
@abnegate abnegate merged commit 196233e into appwrite:master Oct 10, 2024
34 checks passed
@ItzNotABug ItzNotABug deleted the 883-fix-enum-casings branch October 10, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants