Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Deno commands #999

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix: Deno commands #999

merged 1 commit into from
Oct 9, 2024

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Oct 9, 2024

What does this PR do?

  • Applies proper build command for starters used in Appwrite CLI
  • Uses proper command to start Deno during local devleopment

Test Plan

  • Manual QA in Gitpod:

Before:

CleanShot 2024-10-09 at 20 54 31@2x

AFter:

CleanShot 2024-10-09 at 20 54 10@2x

Related PRs and Issues

x

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These still work for older versions of deno?

@Meldiron
Copy link
Contributor Author

Meldiron commented Oct 9, 2024

These still work for older versions of deno?

Yes, cache has been supported for long time. the deno install is actually the new one that wouldn't work. Plus it would still want entrypoint, or deno.json

Start command should work in all versions too. Ther is no version-specific override for Deno start command: https://github.com/open-runtimes/open-runtimes/tree/main/runtimes/deno/versions

@Meldiron Meldiron requested a review from stnguyen90 October 9, 2024 19:00
@Meldiron Meldiron merged commit 412451c into master Oct 9, 2024
34 checks passed
@Meldiron Meldiron deleted the fix-deno-commands branch October 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants