Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Sync with Meilisearch Python Template #218

Merged
merged 1 commit into from
Oct 23, 2023
Merged

✨ Add Sync with Meilisearch Python Template #218

merged 1 commit into from
Oct 23, 2023

Conversation

ishandutta0098
Copy link
Contributor

@ishandutta0098 ishandutta0098 commented Oct 5, 2023 •
edited
Loading

What does this PR do?

Add a Python Template for Sync with Meilisearch

Test Plan

Deployed on Appwrite Cloud, here is the video

sync_with_meilisearch.mp4

Related PRs and Issues

Solves #195

Have you read the Contributing Guidelines on issues?

Yes

@ishandutta0098 ishandutta0098 force-pushed the feat-implement-sync-with-meilisearch-python branch 2 times, most recently from b8c9e6f to 1e44629 Compare October 5, 2023 16:42
@ishandutta0098 ishandutta0098 marked this pull request as draft October 5, 2023 16:45
@ishandutta0098 ishandutta0098 changed the title ✨ Add Sync with Meilisearch Python Template [WIP] ✨ Add Sync with Meilisearch Python Template Oct 5, 2023
@ishandutta0098 ishandutta0098 force-pushed the feat-implement-sync-with-meilisearch-python branch from 1e44629 to 959da70 Compare October 5, 2023 16:48
@ishandutta0098
Copy link
Contributor Author

@gewenyu99 the deployment of the function is successful on the appwrite cloud but the UI is not rendering instead I see the raw html code. Is there something I am missing?
Domain - https://651ee26fe069645e0ee0.appwrite.global/

I have added the required appwrite and Meilisearch API keys to the env variables

@ishandutta0098 ishandutta0098 changed the title [WIP] ✨ Add Sync with Meilisearch Python Template ✨ Add Sync with Meilisearch Python Template Oct 5, 2023
@ishandutta0098 ishandutta0098 marked this pull request as ready for review October 5, 2023 17:09
loks0n
loks0n requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thanks for you contribution!

Can you please create a video testing the function as outline here #195?

loks0n
loks0n requested changes Oct 12, 2023
View reviewed changes
python/sync_with_meilisearch/src/main.py Outdated Show resolved Hide resolved
@ishandutta0098 ishandutta0098 force-pushed the feat-implement-sync-with-meilisearch-python branch from 959da70 to 7943800 Compare October 13, 2023 11:34
loks0n
loks0n requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! One small comment

python/sync_with_meilisearch/README.md Outdated Show resolved Hide resolved
@ishandutta0098 ishandutta0098 force-pushed the feat-implement-sync-with-meilisearch-python branch from 7943800 to 43fbe71 Compare October 13, 2023 16:57
@loks0n loks0n merged commit ecf4a8a into appwrite:main Oct 23, 2023
@loks0n
Copy link
Member

loks0n commented Oct 23, 2023

Thanks for your contribution 🚀

@ishandutta0098
Copy link
Contributor Author

It's my pleasure!

@gewenyu99 gewenyu99 mentioned this pull request Oct 31, 2023
Closed
6 tasks
This was referenced Nov 1, 2023
Closed
Closed
@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

@ishandutta0098 ishandutta0098

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishandutta0098 @loks0n @gewenyu99