-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat implement storage cleaner node #242
Feat implement storage cleaner node #242
Conversation
The only concern i have for this template is that it will take time more than 15minutes(this is the maximum execution time for a function) in case the number of files to be deleted is more than 2k. Cause currently there is no method to do bulk delete in appwrite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some important changes, let's apply those. Feel free to continue discussion if you are not onboard with my approach.
@Meldiron i have pushed the recommended changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing PR! Few small things before we merge
@loks0n I have pushed the requested changes |
🥳 Merged! Thanks for your contribution. |
Thanks a lot @loks0n , @Meldiron , @gewenyu99 , @stnguyen90, @Haimantika 😇. |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
@gewenyu99 my discord username is: gilbish |
Be in touch soon! |
What does this PR do?
This is a PR for the issue #227.
In this i had to create a template to removes all files from the buckets older than X number of days.
Test Plan
I have tested the function template in Appwrite Cloud,
I created 5buckets and added 10images on each bucket, then deleted the files by executing the template.
Here is the video for it: demo video
Related PRs and Issues
This is a PR for the issue #227
Have you read the Contributing Guidelines on issues?
Yes, i have Read the contribution guide.