-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: implemented Appwrite auth functionalities with Vuejs #301
doc: implemented Appwrite auth functionalities with Vuejs #301
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, why are you removing the vue js tutorial?
Please also fix your build before re-requesting review. Do a Thanks! |
Should I make another folder for the vue-auth? |
Okay will do. |
Yes, follow the convention here: https://appwrite.io/docs/tutorials/sveltekit-auth/step-1 Still hidden for now, but should be basically like this. |
Okay on it. |
Hey @gewenyu99 I seem to be getting a parse error when building for a specific code snippet and when I remove that code snippet, the following error comes up: |
Make sure you build on your local machine, code spaces will run out of space :P |
Okay, I am building on my local machine only, will try once again. |
@gewenyu99 I have done some changes and successful build the project. I have made another folder vue-auth and kept the vue tutorial as it is back to the project. |
@Vaibhav91one Thank you, it's the last day of Hacktoberfest, I'm gonna tentatively mark this Hacktoberfest accepted so you get credits from DO. I'll review and continue to work with you on this PR, and when it's merged, you'll get contacted for swags :) |
difficulty: medium | ||
readtime: 40 | ||
--- | ||
## Appwrite: The backend you'll never have to build or maintain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow convention from other published tutorials for what should be in this first page.
I understand you followed the auth deep dive we have, but that is still a draft. This page should be more similar to /tutorials/sveltekit
title: Authentication with Vue | ||
description: Add Authentication to a Vue project using Appwrite. | ||
step: 1 | ||
difficulty: medium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
difficulty: medium | |
difficulty: intermediate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this is a great start.
Before I go in with more reviews, we really care about consistency, and this tutorial's structure is unnecessarily different from what we have in svelte kit.
I like that you also implemented password recovery and verification + protected routes.
They should be further headings:
- Password recovery
- User verification
- Protected routes.
So your headings should be:
- Authentication with SvelteKit
- Create project
- Initialize SDK
- Check if logged in
- Create login page
- Create signup page
- Password recovery
- User verification
- Protected routes
- All set
--- | ||
|
||
|
||
You can create a Vue project using [Vue](https://vuejs.org/guide/quick-start.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing headings
|
||
After running all these commands, you will be able to access you Vue app. | ||
|
||
## Adding Appwrite to Your Vue App |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Headings should be sentence case.
Missing {% #id %}
tags
step: 3 | ||
--- | ||
|
||
# Create project {% #create-project %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just reuse step 2-3 from the vue tutorial. They don't need to be different other than description.
|
||
# Auth store {% #auth-store %} | ||
|
||
Since, we chose pinia for state management during the installatin process.So, we have already setuped our store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, we chose pinia for state management during the installatin process.So, we have already setuped our store. | |
Since, we chose pinia for state management during the installatin process. So, we have already setuped our store. |
@gewenyu99 Okay will do the changes in the morning and Thank you for considering it for hacktoberfest. |
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
@gewenyu99 I have made the changes.
(Thank you for waiting 🤗, Placement season 🥲🤞) |
Hey, looks like a good start for the tutorial. I'll merge this into a branch to continue working on this on our end. Thank you so much! |
c617f94
into
appwrite:feat-add-vue-authentication-deepdive
Your welcome and Thank you for the guidance. 🚀 |
Hey @gewenyu99 I was just curious that, is this still under review? If there is anything I can do to help, feel free to ask. |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
Profile Link: https://discordapp.com/users/762914716652797982 |
Will reach out soon. Appreciate your patience! |
What does this PR do?
This PR provides a tutorial for how to use appwrite authentication with Vue
Test Plan
I have made the app while creating the tutorial.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes