Experimental/continuation local storage with fbt runtime #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayhadrin
commented
May 18, 2020
| @@ -26,6 +26,7 @@ | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.9.2", | |||
| "babel-plugin-fbt-runtime": "^0.9.4", | |||
| "cls-hooked": "^4.2.2", | |||
There was a problem hiding this comment.
Used cls-hooked instead of node-continuation-local-storage:
See othiym23/node-continuation-local-storage#98 (comment) for more info.
There's maybe hopes to find something more elegant with this other Express plugin: othiym23/node-continuation-local-storage#98 (comment)
kayhadrin
commented
May 18, 2020
src/helpers/translations/index.ts
Outdated
Comment on lines
16
to
28
| getViewerContext() { | ||
| if (!!isNode && continuationLocalStorage != null) { | ||
| const sessionLocale = continuationLocalStorage.getNamespace('session').get('locale'); | ||
| if (!sessionLocale) { | ||
| throw new Error('Unknown sessionLocale'); | ||
| } | ||
| locale = sessionLocale; | ||
| } | ||
| return { | ||
| GENDER: IntlVariations.GENDER_UNKNOWN, | ||
| locale: locale || DEFAULT_LOCALE | ||
| }; | ||
| } |
There was a problem hiding this comment.
Depends on a new (WIP) Fbt runtime API from this PR: facebook/fbt#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how the continuation-local-storage npm module (actually, a fork of it) could be used to keep track of the initial locale of a web request, when used with the fbt runtime JS API.
Depends on a new (WIP) Fbt runtime API from this PR: facebook/fbt#142
Note that the vanilla continuation-local-storage module is not
awaitfriendly, so you might want to investigate how to make it work best for your purposes.For now, I used cls-hooked instead of node-continuation-local-storage:
See othiym23/node-continuation-local-storage#98 (comment) for more info.
There's maybe hopes to find something more elegant with this other Express plugin: othiym23/node-continuation-local-storage#98 (comment)