Individual slits as devices #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be best we can do, given ophyd. |
|
Because of the problem with the |
|
All good, just ping me when it's good to go |
prjemian
reviewed
Oct 18, 2024
| super().__init__(prefix, *args, **kwargs) | ||
|
|
||
| # Real motors that directly control the slits | ||
| hp = FCpt(EpicsMotor, "{motor_prefix}:{_h_positive_motor}", labels={"motors"}) |
There was a problem hiding this comment.
Following a BCDA convention, the : is defined by the prefix. Several suggestions follow:
Suggested change
| hp = FCpt(EpicsMotor, "{motor_prefix}:{_h_positive_motor}", labels={"motors"}) | |
| hp = FCpt(EpicsMotor, "{motor_prefix}{_h_positive_motor}", labels={"motors"}) |
prjemian
reviewed
Oct 18, 2024
|
|
||
| # Real motors that directly control the slits | ||
| hp = FCpt(EpicsMotor, "{motor_prefix}:{_h_positive_motor}", labels={"motors"}) | ||
| hn = FCpt(EpicsMotor, "{motor_prefix}:{_h_negative_motor}", labels={"motors"}) |
There was a problem hiding this comment.
Suggested change
| hn = FCpt(EpicsMotor, "{motor_prefix}:{_h_negative_motor}", labels={"motors"}) | |
| hn = FCpt(EpicsMotor, "{motor_prefix}{_h_negative_motor}", labels={"motors"}) |
prjemian
reviewed
Oct 18, 2024
| # Real motors that directly control the slits | ||
| hp = FCpt(EpicsMotor, "{motor_prefix}:{_h_positive_motor}", labels={"motors"}) | ||
| hn = FCpt(EpicsMotor, "{motor_prefix}:{_h_negative_motor}", labels={"motors"}) | ||
| vp = FCpt(EpicsMotor, "{motor_prefix}:{_v_positive_motor}", labels={"motors"}) |
There was a problem hiding this comment.
Suggested change
| vp = FCpt(EpicsMotor, "{motor_prefix}:{_v_positive_motor}", labels={"motors"}) | |
| vp = FCpt(EpicsMotor, "{motor_prefix}{_v_positive_motor}", labels={"motors"}) |
prjemian
reviewed
Oct 18, 2024
| hp = FCpt(EpicsMotor, "{motor_prefix}:{_h_positive_motor}", labels={"motors"}) | ||
| hn = FCpt(EpicsMotor, "{motor_prefix}:{_h_negative_motor}", labels={"motors"}) | ||
| vp = FCpt(EpicsMotor, "{motor_prefix}:{_v_positive_motor}", labels={"motors"}) | ||
| vn = FCpt(EpicsMotor, "{motor_prefix}:{_v_negative_motor}", labels={"motors"}) |
There was a problem hiding this comment.
Suggested change
| vn = FCpt(EpicsMotor, "{motor_prefix}:{_v_negative_motor}", labels={"motors"}) | |
| vn = FCpt(EpicsMotor, "{motor_prefix}{_v_negative_motor}", labels={"motors"}) |
prjemian
reviewed
Oct 18, 2024
|
|
||
|
|
||
| i_sl9 = IndividualSlits( | ||
| prefix="8ideSoft:CR8-I2:US", |
There was a problem hiding this comment.
Suggested change
| prefix="8ideSoft:CR8-I2:US", | |
| prefix="8ideSoft:CR8-I2:US:", |
prjemian
reviewed
Oct 18, 2024
| ) | ||
|
|
||
| i_sl5 = IndividualSlits( | ||
| prefix="8idiSoft:CR8-E2:US", |
There was a problem hiding this comment.
Suggested change
| prefix="8idiSoft:CR8-E2:US", | |
| prefix="8idiSoft:CR8-E2:US:", |
prjemian
reviewed
Oct 18, 2024
| vn = FCpt(EpicsMotor, "{motor_prefix}:{_v_negative_motor}", labels={"motors"}) | ||
|
|
||
|
|
||
| i_sl9 = IndividualSlits( |
There was a problem hiding this comment.
The name here does not suggest that this object contains the motors.
Suggested change
| i_sl9 = IndividualSlits( | |
| sl9_motors = IndividualSlits( |
and make the name= match on Line 57. Same for other(s) below.
prjemian
reviewed
Oct 18, 2024
| logger.info(__file__) | ||
|
|
||
|
|
||
| class IndividualSlits(Device): |
There was a problem hiding this comment.
There is an MotorBundle object that is often overlooked. It might be appropriate to switch to that here from Device. It's docs state:
This provides better default behavior for 'hints'.
prjemian
reviewed
Oct 18, 2024
|
Could not test this at the beamline. Could not connect with the EPICS motor PVs. In [9]: i_sl9.hp
Out[9]: EpicsMotor(prefix='8ideSoft:CR8-I2:m12', name='i_sl9_hp', parent='i_sl9', settle_time=0.0, timeout=None, read_attrs=['user_readback', 'user_setpoint'], configuration_attrs=['user_offset', 'user_offset_dir', 'velocity', 'acceleration', 'motor_egu'])
In [10]: !caget 8ideSoft:CR8-I2:m12
Channel connect timed out: '8ideSoft:CR8-I2:m12' not found.
In [11]: !cainfo 8idiSoft:CR8-E2:US:m4
Channel connect timed out: '8idiSoft:CR8-E2:US:m4' not found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of testing I believe that the best way forward is just creating a separate device for the individual slits. OPHYD does not lend itself to what we are trying to do. Open to others solutions