feat: telemetry for all commands #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make it so all commands run with `aptible-cli` will send a tuna event with the following info: - user email - user -or- org id - format (e.g. text or json) - command run - options provided to command This is the foundation for us to evaluate usage and provide us with the ability to make decisions about the future direction of the CLI. I tried to find a `before` hook for Thor but it looks like it doesn't exist: https://stackoverflow.com/questions/61855861/is-there-a-way-to-add-hooks-to-a-thor-class-in-order-to-run-code-before-after-al
There was a problem hiding this comment.
Does this actually work with httpclient? I get SSL verification errors when i bundle exec it from source, and i also just hacked this change into my toolbelt version, and get the same certificate verify failed error, even though this is a valid let's encrypt certificate? We don't use LE certs for auth.aptible.com or api.aptible.com (the other endpoints the CLI talks to) so i don't know exactly what is to blame here:
You could bump the version in this PR if you don't want to open another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make it so all commands run with
aptible-cliwill send a tuna event with the following info:This is the foundation for us to evaluate usage and provide us with the ability to make decisions about the future direction of the CLI.
I tried to find a
beforehook for Thor but it looks like it doesn't exist: https://stackoverflow.com/questions/61855861/is-there-a-way-to-add-hooks-to-a-thor-class-in-order-to-run-code-before-after-al