Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration variables to be set during deployment #18

Merged
merged 1 commit into from
May 16, 2023

Conversation

gwax
Copy link
Contributor

@gwax gwax commented Apr 21, 2023

Here we add a new optional parameter to the action so that users may set aptible config variables during the deploy action. This is useful for cases where config values might depend on information present during the Github workflow that is calling the action (for example, the git sha used to build the image).

Example usage is added to the documentation as well.

Here we add a new optional parameter to the action so that users
may set aptible config variables during the deploy action. This
is useful for cases where config values might depend on information
present during the Github workflow that is calling the action
(for example, the git sha used to build the image).

Example usage is added to the documentation as well.
@gwax gwax requested a review from aguilinger as a code owner April 21, 2023 00:06
@josh-
Copy link

josh- commented May 16, 2023

Currently using this fork to set config values as part of a deployment and it works super well - would be fantastic if this was able to be merged into this official repo 🙏

Copy link
Member

@aguilinger aguilinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@aguilinger aguilinger merged commit 386b3a2 into aptible:master May 16, 2023
@aguilinger
Copy link
Member

@josh-
Copy link

josh- commented May 16, 2023

Amazing! Thanks so much @aguilinger 🎉

@josh-
Copy link

josh- commented May 16, 2023

@aguilinger just a quick heads up that it looks like the "Keep the versions up-to-date" workflow has failed which means I can't use this new fracture when referencing version @v1 of the action. (Manually specifying @v1.4.0 works though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants