-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: git push #24
feat: git push #24
Conversation
BREAKING CHANGE: `type` is now required (choices: `git` or `docker`)
action.yml
Outdated
docker_img: | ||
description: 'Docker image' | ||
type: | ||
description: 'Deploy strategy "git" or "deploy"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'Deploy strategy "git" or "deploy"' | |
description: 'Deploy strategy "git" or "docker"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
entrypoint.sh
Outdated
BRANCH="$GITHUB_REF_NAME" | ||
fi | ||
if [ -z "$BRANCH" ]; then | ||
echo "Aborting: branch is not set; this shouldn't happen, please contact support" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should probably specify Aptible support since it might seem like we're pointing to GHA support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
@@ -31,4 +38,5 @@ outputs: | |||
description: "The Success/Failure of the action" | |||
runs: | |||
using: 'docker' | |||
image: 'Dockerfile' | |||
# image: 'Dockerfile' | |||
image: docker://quay.io/aptible/aptible-deploy-action:v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you re-using this tag from last time? And did you build and push properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, same tag. I just built and pushed our recent changes.
FEAT
git push
Approach
We tried to make this as congruent as possible with the current Direct Docker Image Deploy strategy. In that effort, we wanted to support
git push
without requiring yet another authentication secret -- the SSH private key -- so we had to jump through some hoops to use our Aptible access token for pushing to our git remote.Security Considerations
We are interfacing directly with
primetime
in order to perform agit push
using just an Aptible token. This makes this paradigm more visible to the outside world, something to think about.Previous Attempt
#21
The main difference between this PR and that previous one is we now default
type
todocker
which means it should not break anyone's current GHA.