[AIP-5] Soulbound and Freezing Token Standard #16

JacobADevore · 2022-12-08T15:38:28Z

No description provided.

areshand · 2022-12-09T23:54:59Z

aips/aip-4.md

+
+Modifications required to the current [Aptos-Token](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-token/sources/token.move) implementation:
+
+- Append “soulbound: bool” too *Tokens* and *Collections.*


what is the usage of soulbound collections?

After further thought, I do not believe Collections requires the soulbound property. Good call.

what is the usage of soulbound collections?

Gift cards

Birthday Wishes

Lifetime community memberships

These are a few that i can think at this moment but there're more.

areshand · 2022-12-10T00:05:27Z

aips/aip-4.md

+- Validate before any transfer execution to ensure the token isn’t soulbound.
+
+```rust
+/// Executed when a specific token_id is set or updated to soulbound, according to the parameter "bounded".


does this mean a token can mutate between a soulbound and non-soulbound token? In my mind, soulbound should not be transferrable after minting to its owner

No, the soulbound property should never be mutatable. The validation checks the existing transfer functions to ensure that the current token is not soulbound. This validation is needed as soulbound and non-soulbound tokens can coexist.

areshand · 2022-12-10T00:13:01Z

aips/aip-4.md

@@ -0,0 +1,78 @@
+# AIP-4: Multi-Composable Token Standard


Thank you for submitting the PR. please also create a discussion issue like this one #15. It is easier to keep the discussion in an issue

Sure thing - #18

Hey @JacobADevore could you please add the header like other AIPs? Let's make this one AIP-5. once you updated, we can land this draft and iterate on it

Hey @JacobADevore could you please add the header like other AIPs? Let's make this one AIP-5. once you updated, we can land this draft and iterate on it

Sure thing! Does that suffice?

You need to update the file name too

Got it! Sorry about that.

davidiw

Really exciting to have our first proposal from the community. I look forward to working with you more on this topic :)

davidiw · 2022-12-12T20:59:05Z

aips/aip-4.md

+
+Modifications required to the current [Aptos-Token](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-token/sources/token.move) implementation:
+
+- Append “soulbound: bool” too *Tokens*


You should look at https://github.com/aptos-labs/aptos-core/blob/992386076118e2b6deff599c8cb7cca684807858/aptos-move/framework/aptos-token/sources/token.move#L36

this is the only way to add new fields to tokens.

will look into it.

davidiw · 2022-12-12T20:59:59Z

aips/aip-4.md

+Modifications required to the current [Aptos-Token](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-token/sources/token.move) implementation:
+
+- Append “soulbound: bool” too *Tokens*
+- Minting of soulbound tokens can only be handled through *“claims”*. After a soulbound NFT has been claimed it is locked to the receiver with the only valid operation being *“burn”,* if applicable to the token’s configuration*.*


the biggest issue I see is that soulbound would increase operating costs for everyone, but I'm not sure by how much. Every withdraw operation would go up by the cost to check to see if it is set.

agreed. looking into.

davidiw · 2022-12-12T21:00:36Z

aips/aip-4.md

+
+- Append “soulbound: bool” too *Tokens*
+- Minting of soulbound tokens can only be handled through *“claims”*. After a soulbound NFT has been claimed it is locked to the receiver with the only valid operation being *“burn”,* if applicable to the token’s configuration*.*
+- Validate before any transfer execution to ensure the token isn’t soulbound.


simply verify the withdraw

Really exciting to have our first proposal from the community. I look forward to working with you more on this topic :)

Thank you @davidiw for all the amazing feedback here!!

davidiw · 2022-12-12T21:01:16Z

aips/aip-4.md

+
+### Suggested I**mplementation Timeline**
+
+To be determined.


I think this is one of those things where you should try a couple implementations and come back with the pros and cons. It isn't clear to me that there is a perfect solution here.

Will do, working through it with @areshand :)

ghost · 2023-01-09T08:35:10Z

0x3::token is really gas heavy enough, why we should keep change that?
I recommend an another approach: clone 0x3::token standard to be 0x3::soulbound_token, so you don't need do a verify for withdraw/deposit.

alnoki · 2023-01-22T12:49:58Z

Comment moved to #18

davidiw · 2023-04-16T16:01:31Z

With the progress towards token v2 that supports this inherently and with minimal cost, do we still want to pursue this?

Context:

ghost · 2023-04-16T23:35:22Z

Why should be so hard? just do move_to(&signer, YourTokenName {}) then make it able to query from another contract, next to frozen the contract then, the SBT is made out.

Of course, by this method, the user need to interact the contract, but this contract has been frozen and open source, 100% safe,

davidiw · 2023-04-17T03:31:55Z

Why should be so hard? just do move_to(&signer, YourTokenName {}) then make it able to query from another contract, next to frozen the contract then, the SBT is made out.

Of course, by this method, the user need to interact the contract, but this contract has been frozen and open source, 100% safe,

@e99243506bigplay, I agree, the goal of this AIP was to make this inline and a part of the existing core code, which would have ramifications to every token. If someone wants to push a TokenV1 AIP that supports soul bound as you proposed, I think that would be acceptable from a framework perspective -- the question is would it be good for @JacobADevore and would other ecosystem partners adopt.

JacobADevore · 2023-04-17T16:17:29Z

Why should be so hard? just do move_to(&signer, YourTokenName {}) then make it able to query from another contract, next to frozen the contract then, the SBT is made out.
Of course, by this method, the user need to interact the contract, but this contract has been frozen and open source, 100% safe,

@e99243506bigplay, I agree, the goal of this AIP was to make this inline and a part of the existing core code, which would have ramifications to every token. If someone wants to push a TokenV1 AIP that supports soul bound as you proposed, I think that would be acceptable from a framework perspective -- the question is would it be good for @JacobADevore and would other ecosystem partners adopt.

Hey @davidiw, I think it would be great if you can extend or fork your https://github.com/aptos-labs/aptos-core/tree/main/aptos-move/move-examples/token_objects project and show an example of how soul bound NFTs would come to life with the new object pattern.

davidiw · 2023-07-14T01:50:25Z

Why should be so hard? just do move_to(&signer, YourTokenName {}) then make it able to query from another contract, next to frozen the contract then, the SBT is made out.
Of course, by this method, the user need to interact the contract, but this contract has been frozen and open source, 100% safe,

@e99243506bigplay, I agree, the goal of this AIP was to make this inline and a part of the existing core code, which would have ramifications to every token. If someone wants to push a TokenV1 AIP that supports soul bound as you proposed, I think that would be acceptable from a framework perspective -- the question is would it be good for @JacobADevore and would other ecosystem partners adopt.

Hey @davidiw, I think it would be great if you can extend or fork your https://github.com/aptos-labs/aptos-core/tree/main/aptos-move/move-examples/token_objects project and show an example of how soul bound NFTs would come to life with the new object pattern.

Take a look here:
https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-token-objects/sources/aptos_token.move#L189

Any objections to closing this and focusing on TokenV2? There are already many wallets that support it: Petra, Fewcha, Rise, and more coming soon :)

thepomeranian · 2023-07-18T20:30:11Z

Closing this for now due to inactivity and no actionable items

JacobADevore added 2 commits December 8, 2022 10:38

AIP-4: Multi-Composable Token Standard

313407f

Rename aip-4 to aip-4.md

fb3a417

sherry-x requested review from sherry-x and davidiw December 8, 2022 23:02

areshand reviewed Dec 9, 2022

View reviewed changes

areshand reviewed Dec 10, 2022

View reviewed changes

remove soulbound property from collections

51e67c8

JacobADevore mentioned this pull request Dec 10, 2022

[AIP-5][Discussion] Soulbound and Freezing Token Standard #18

Closed

davidiw reviewed Dec 12, 2022

View reviewed changes

JacobADevore changed the title ~~AIP-4: Multi-Composable Token Standard~~ [AIP-5] Multi-Composable Token Standard Dec 20, 2022

JacobADevore added 2 commits December 20, 2022 18:58

rename from aip-4 to aip-5

665a2d0

Update implementations

a602265

JacobADevore changed the title ~~[AIP-5] Multi-Composable Token Standard~~ [AIP-5] Soulbound and Freezing Token Standard Dec 22, 2022

Update name and proposal

44562d3

thepomeranian closed this Jul 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIP-5] Soulbound and Freezing Token Standard #16

[AIP-5] Soulbound and Freezing Token Standard #16

JacobADevore commented Dec 8, 2022

areshand Dec 9, 2022

JacobADevore Dec 10, 2022

subashmokshya Dec 23, 2022

areshand Dec 10, 2022

JacobADevore Dec 10, 2022

areshand Dec 10, 2022

JacobADevore Dec 10, 2022

sherry-x Dec 20, 2022

JacobADevore Dec 20, 2022

sherry-x Dec 20, 2022

JacobADevore Dec 20, 2022

davidiw left a comment

davidiw Dec 12, 2022

JacobADevore Dec 20, 2022

davidiw Dec 12, 2022

JacobADevore Dec 20, 2022

davidiw Dec 12, 2022

JacobADevore Dec 20, 2022

davidiw Dec 12, 2022

JacobADevore Dec 20, 2022

ghost commented Jan 9, 2023

alnoki commented Jan 22, 2023 •

edited

Loading

davidiw commented Apr 16, 2023 •

edited

Loading

ghost commented Apr 16, 2023 •

edited by ghost

Loading

davidiw commented Apr 17, 2023

JacobADevore commented Apr 17, 2023

davidiw commented Jul 14, 2023

thepomeranian commented Jul 18, 2023


		Modifications required to the current [Aptos-Token](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-token/sources/token.move) implementation:

		- Append “soulbound: bool” too Tokens and Collections.


		Modifications required to the current [Aptos-Token](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-token/sources/token.move) implementation:

		- Append “soulbound: bool” too Tokens

[AIP-5] Soulbound and Freezing Token Standard #16

[AIP-5] Soulbound and Freezing Token Standard #16

Conversation

JacobADevore commented Dec 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidiw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 9, 2023

alnoki commented Jan 22, 2023 • edited Loading

davidiw commented Apr 16, 2023 • edited Loading

ghost commented Apr 16, 2023 • edited by ghost Loading

davidiw commented Apr 17, 2023

JacobADevore commented Apr 17, 2023

davidiw commented Jul 14, 2023

thepomeranian commented Jul 18, 2023

alnoki commented Jan 22, 2023 •

edited

Loading

davidiw commented Apr 16, 2023 •

edited

Loading

ghost commented Apr 16, 2023 •

edited by ghost

Loading