AIP-X Increase coin symbol limit to 32 bytes #558
Conversation
|
|
||
| ## Summary | ||
|
|
||
| Currently, emojis are 8-bytes, and could be longer. This AIP proposes to increase the coin symbol byte length to allow |
There was a problem hiding this comment.
emojis are 8-bytes
This is factually incorrect, counterexample (3 bytes): ⏰ https://github.com/econia-labs/emojicoin-dot-fun/blob/902b89a3b8c9606208eda65118bbe9c4d0a58ed5/src/move/emojicoin_dot_fun/sources/hex_codes.move#L23
There was a problem hiding this comment.
Okay, this is a technicality typo... Where the "max" is 8 bytes correct?
There was a problem hiding this comment.
There are some that are more than 8 bytes, for example the Scottish flag 🏴 is 28 bytes...:
There was a problem hiding this comment.
What do you propose is the longest then?
I think this provide a good balance. Not too long, allows the scottish flag, but doesn't necessarily support really long ones 🧑🏾❤️🧑🏽
https://unicode.org/Public/emoji/13.1/emoji-zwj-sequences.txt
There was a problem hiding this comment.
the longest
There are emojis that are even longer than 28 bytes, and we had to take some of them out to keep package under size limit: https://github.com/econia-labs/emojicoin-dot-fun/blob/f2db7f1ffb2107b792f3d94c30b1c2d96d26b66b/src/python/move_emojis/utils/data_parser.py#L203-L220
Also pretty much any combination that combines modifiers like skin color or man/woman (especially for the 4-person families) can quickly add up
gregnazario
changed the title
No description provided.