Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create PR to bump homebrew version of CLI, don't build MacOS binary #10814

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Nov 7, 2023

Description

We've learned in the last few months that brew isn't as magic as I thought and every time we release a CLI, someone actually creates a PR to bump the version in homebrew-core manually. This means sometimes it can take a while.

To make this process faster, this PR adds a step to the CLI release that submits that version bump PR automatically.

Test Plan

This PR was opened thanks to the new job added here: Homebrew/homebrew-core#153591.

@banool banool force-pushed the banool/create-brew-pr branch 3 times, most recently from 83a2ee2 to 2ac0587 Compare November 7, 2023 16:30
@banool banool changed the title Automatically create PR to bump homebrew version of CLI Automatically create PR to bump homebrew version of CLI, don't build MacOS binary Nov 7, 2023
@banool banool force-pushed the banool/create-brew-pr branch 9 times, most recently from ddd75d1 to d3ed481 Compare November 7, 2023 20:13
@banool banool marked this pull request as ready for review November 7, 2023 20:13
@banool banool requested review from gregnazario, 0xmigo and a team as code owners November 7, 2023 20:13
Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to update the doc page for CLI installation as well / any other scripts that use it.

Alternatively for now we could just build the x86 one and communicate it accordingly

@banool
Copy link
Contributor Author

banool commented Nov 7, 2023

I'd say we should not build MacOS at all ourselves, it's just confusing. Better to mandate brew imo. Or if we do build it, we should build a universal binary.

@banool banool enabled auto-merge (squash) November 7, 2023 20:34
@gregnazario
Copy link
Contributor

I'd say we should not build MacOS at all ourselves, it's just confusing. Better to mandate brew imo. Or if we do build it, we should build a universal binary.

Yes, this is similar to how the Linux build is also confusing if you're trying to use it elsewhere

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@0xmigo 0xmigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please mandate brew. TBH with the previous openSSL stuff and managing all of those dependency without brew was a real pain.

This comment has been minimized.

This comment has been minimized.

@banool banool disabled auto-merge November 7, 2023 22:39
@banool banool enabled auto-merge (squash) November 7, 2023 22:39

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

✅ Forge suite compat success on aptos-node-v1.7.3 ==> ca46013d9e052aa0d41231dadb3fe869e2cfc97e

Compatibility test results for aptos-node-v1.7.3 ==> ca46013d9e052aa0d41231dadb3fe869e2cfc97e (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3222 txn/s, latency: 6576 ms, (p50: 6300 ms, p90: 9900 ms, p99: 15400 ms), latency samples: 186920
2. Upgrading first Validator to new version: ca46013d9e052aa0d41231dadb3fe869e2cfc97e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1819 txn/s, latency: 16072 ms, (p50: 19500 ms, p90: 22000 ms, p99: 23600 ms), latency samples: 90980
3. Upgrading rest of first batch to new version: ca46013d9e052aa0d41231dadb3fe869e2cfc97e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1816 txn/s, latency: 15808 ms, (p50: 19900 ms, p90: 22000 ms, p99: 22900 ms), latency samples: 92620
4. upgrading second batch to new version: ca46013d9e052aa0d41231dadb3fe869e2cfc97e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3599 txn/s, latency: 8776 ms, (p50: 9900 ms, p90: 12100 ms, p99: 12400 ms), latency samples: 143960
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> ca46013d9e052aa0d41231dadb3fe869e2cfc97e passed
Test Ok

Copy link
Contributor

github-actions bot commented Nov 7, 2023

✅ Forge suite realistic_env_max_load success on ca46013d9e052aa0d41231dadb3fe869e2cfc97e

two traffics test: inner traffic : committed: 8189 txn/s, latency: 4792 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10600 ms), latency samples: 3529740
two traffics test : committed: 100 txn/s, latency: 2196 ms, (p50: 2100 ms, p90: 2600 ms, p99: 3700 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.232, avg: 0.199", "QsPosToProposal: max: 0.165, avg: 0.149", "ConsensusProposalToOrdered: max: 0.611, avg: 0.562", "ConsensusOrderedToCommit: max: 0.532, avg: 0.508", "ConsensusProposalToCommit: max: 1.090, avg: 1.070"]
Max round gap was 1 [limit 4] at version 1670449. Max no progress secs was 4.351202 [limit 10] at version 1670449.
Test Ok

@banool banool merged commit 50d0435 into main Nov 7, 2023
124 of 135 checks passed
@banool banool deleted the banool/create-brew-pr branch November 7, 2023 23:08
Copy link
Contributor

github-actions bot commented Nov 7, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> ca46013d9e052aa0d41231dadb3fe869e2cfc97e

Compatibility test results for aptos-node-v1.7.3 ==> ca46013d9e052aa0d41231dadb3fe869e2cfc97e (PR)
Upgrade the nodes to version: ca46013d9e052aa0d41231dadb3fe869e2cfc97e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4197 txn/s, latency: 4836 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8300 ms), latency samples: 243480
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> ca46013d9e052aa0d41231dadb3fe869e2cfc97e passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants