Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][1.12] [quorum store] increase max per-validator TPS constraint from 2K to 4K (#13362) #13382

Merged
merged 1 commit into from
May 23, 2024

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented May 22, 2024

Description

Make the max constraint in quorum store backpressure larger.

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

#13362)

## Description
Make the max constraint in quorum store backpressure larger.
Copy link

trunk-io bot commented May 22, 2024

@bchocho bchocho changed the title [quorum store] increase max per-validator TPS constraint from 2K to 4… [cherry-pick][1.12] [quorum store] increase max per-validator TPS constraint from 2K to 4K (#13362) May 22, 2024
@bchocho bchocho marked this pull request as ready for review May 22, 2024 08:44
@sherry-x sherry-x enabled auto-merge (squash) May 22, 2024 22:30

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4863eb7366c6999f9d3d612cc00318cc3782bae4

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4863eb7366c6999f9d3d612cc00318cc3782bae4 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6701 txn/s, latency: 4965 ms, (p50: 4800 ms, p90: 8600 ms, p99: 9800 ms), latency samples: 234540
2. Upgrading first Validator to new version: 4863eb7366c6999f9d3d612cc00318cc3782bae4
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2833 txn/s, latency: 11149 ms, (p50: 9100 ms, p90: 20000 ms, p99: 20500 ms), latency samples: 110500
3. Upgrading rest of first batch to new version: 4863eb7366c6999f9d3d612cc00318cc3782bae4
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3335 txn/s, latency: 9550 ms, (p50: 9600 ms, p90: 14200 ms, p99: 14600 ms), latency samples: 136740
4. upgrading second batch to new version: 4863eb7366c6999f9d3d612cc00318cc3782bae4
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4881 txn/s, latency: 6786 ms, (p50: 5200 ms, p90: 11800 ms, p99: 12500 ms), latency samples: 170840
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4863eb7366c6999f9d3d612cc00318cc3782bae4 passed
Test Ok

@bchocho bchocho requested a review from zekun000 May 23, 2024 00:05

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4863eb7366c6999f9d3d612cc00318cc3782bae4

two traffics test: inner traffic : committed: 7834 txn/s, latency: 5006 ms, (p50: 4800 ms, p90: 6300 ms, p99: 10300 ms), latency samples: 3392240
two traffics test : committed: 100 txn/s, latency: 1984 ms, (p50: 1900 ms, p90: 2100 ms, p99: 6800 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.215, avg: 0.205", "QsPosToProposal: max: 0.319, avg: 0.257", "ConsensusProposalToOrdered: max: 0.468, avg: 0.429", "ConsensusOrderedToCommit: max: 0.399, avg: 0.380", "ConsensusProposalToCommit: max: 0.846, avg: 0.810"]
Max round gap was 1 [limit 4] at version 1724465. Max no progress secs was 4.627676 [limit 15] at version 1724465.
Test Ok

@sherry-x sherry-x disabled auto-merge May 23, 2024 16:12
@sherry-x sherry-x merged commit c1cb7a0 into aptos-release-v1.12 May 23, 2024
83 of 84 checks passed
@sherry-x sherry-x deleted the brian/bump-up-batch-creation-1-12 branch May 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants