Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Install Google Cloud CLI in the tools image #13535

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Jun 3, 2024

The backup tool has switched from the deprecated gsutil CLI to gcloud storage.

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

The backup tool has switched from the deprecated `gsutil` CLI to
`gcloud storage`.
@areshand areshand requested a review from a team as a code owner June 3, 2024 22:55
Copy link

trunk-io bot commented Jun 3, 2024

⏱️ 4h 39m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 36m 🟩
rust-smoke-tests 34m 🟥🟥
rust-targeted-unit-tests 33m 🟩
execution-performance / single-node-performance 25m 🟥
rust-move-tests 20m 🟩
rust-images / rust-all 19m 🟩
forge-framework-upgrade-test / forge 17m 🟩
forge-e2e-test / forge 15m 🟩
forge-compat-test / forge 13m 🟩
rust-lints 13m 🟩
cli-e2e-tests / run-cli-tests 11m 🟥
run-tests-main-branch 9m 🟩🟩
test-target-determinator 6m 🟩🟩
rust-build-cached-packages 5m 🟩
check-dynamic-deps 4m 🟩🟩🟩
general-lints 4m 🟩🟩
check 4m 🟩
execution-performance / test-target-determinator 3m 🟩
semgrep/ci 1m 🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 1m 🟩
file_change_determinator 41s 🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 22s 🟩🟩
permission-check 12s 🟩🟩🟩
permission-check 11s 🟩🟩🟩
permission-check 6s 🟩🟩🟩
permission-check 6s 🟩🟩🟩
permission-check 5s 🟩🟩
determine-docker-build-metadata 3s 🟩🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 11m 7m +56%
rust-targeted-unit-tests 28m 18m +53%
rust-move-tests 14m 9m +52%
rust-lints 8m 7m +23%

settingsfeedbackdocs ⋅ learn more about trunk.io

@areshand areshand added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Jun 3, 2024
@areshand areshand changed the title Install Google Cloud CLI in the tools image Cherry pick Install Google Cloud CLI in the tools image Jun 3, 2024
@sherry-x sherry-x requested a review from msmouse June 3, 2024 22:59
@sherry-x sherry-x enabled auto-merge (squash) June 3, 2024 23:02

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite compat success on c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> cdd1b498131789fb9a6117e34277623e45622b80

Compatibility test results for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> cdd1b498131789fb9a6117e34277623e45622b80 (PR)
1. Check liveness of validators at old version: c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e
compatibility::simple-validator-upgrade::liveness-check : committed: 7071.64936741926 txn/s, latency: 4675.14533026857 ms, (p50: 5000 ms, p90: 6600 ms, p99: 7300 ms), latency samples: 247980
2. Upgrading first Validator to new version: cdd1b498131789fb9a6117e34277623e45622b80
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2732.7009576166306 txn/s, latency: 11230.383375067073 ms, (p50: 13000 ms, p90: 15400 ms, p99: 17600 ms), latency samples: 111820
3. Upgrading rest of first batch to new version: cdd1b498131789fb9a6117e34277623e45622b80
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3378.919729415322 txn/s, latency: 9130.035586236809 ms, (p50: 9000 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 138340
4. upgrading second batch to new version: cdd1b498131789fb9a6117e34277623e45622b80
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6375.180634869911 txn/s, latency: 5111.257262117727 ms, (p50: 4800 ms, p90: 8100 ms, p99: 9400 ms), latency samples: 234780
5. check swarm health
Compatibility test for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> cdd1b498131789fb9a6117e34277623e45622b80 passed
Test Ok

@sherry-x sherry-x disabled auto-merge June 3, 2024 23:32
Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite realistic_env_max_load success on cdd1b498131789fb9a6117e34277623e45622b80

two traffics test: inner traffic : committed: 8117.838642403998 txn/s, latency: 4799.273552956356 ms, (p50: 4600 ms, p90: 6200 ms, p99: 10500 ms), latency samples: 3565200
two traffics test : committed: 100.06363178947147 txn/s, latency: 2128.516129032258 ms, (p50: 1900 ms, p90: 2200 ms, p99: 7800 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.210, avg: 0.203", "QsPosToProposal: max: 0.238, avg: 0.226", "ConsensusProposalToOrdered: max: 0.423, avg: 0.391", "ConsensusOrderedToCommit: max: 0.374, avg: 0.361", "ConsensusProposalToCommit: max: 0.764, avg: 0.753"]
Max round gap was 1 [limit 4] at version 1072813. Max no progress secs was 4.89246 [limit 15] at version 1072813.
Test Ok

@sherry-x sherry-x merged commit 7a2249e into aptos-release-v1.13 Jun 3, 2024
131 of 154 checks passed
@sherry-x sherry-x deleted the release_1_13_2 branch June 3, 2024 23:32
Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite framework_upgrade success on c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> cdd1b498131789fb9a6117e34277623e45622b80

Compatibility test results for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> cdd1b498131789fb9a6117e34277623e45622b80 (PR)
Upgrade the nodes to version: cdd1b498131789fb9a6117e34277623e45622b80
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1108.0161272793896 txn/s, submitted: 1110.8792180475532 txn/s, failed submission: 2.863090768163797 txn/s, expired: 2.863090768163797 txn/s, latency: 2864.8368713973364 ms, (p50: 2100 ms, p90: 5400 ms, p99: 9200 ms), latency samples: 100620
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1101.1771383673995 txn/s, submitted: 1102.5304900327424 txn/s, failed submission: 1.3533516653429736 txn/s, expired: 1.3533516653429736 txn/s, latency: 2822.0656493240476 ms, (p50: 2100 ms, p90: 4900 ms, p99: 11000 ms), latency samples: 97640
5. check swarm health
Compatibility test for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> cdd1b498131789fb9a6117e34277623e45622b80 passed
Upgrade the remaining nodes to version: cdd1b498131789fb9a6117e34277623e45622b80
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1132.5571146744667 txn/s, submitted: 1135.1742310573077 txn/s, failed submission: 2.617116382841055 txn/s, expired: 2.617116382841055 txn/s, latency: 2781.973339110341 ms, (p50: 2100 ms, p90: 5100 ms, p99: 9300 ms), latency samples: 103860
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants