Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick keyless txn simulation fix in v1.13 #13557

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Jun 4, 2024

Description

Link to PR

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jun 4, 2024

⏱️ 7h 23m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 1h 18m 🟩🟩
execution-performance / single-node-performance 52m 🟥🟥
rust-targeted-unit-tests 50m 🟩🟩
rust-smoke-tests 41m 🟥
forge-framework-upgrade-test / forge 28m 🟩
forge-e2e-test / forge 28m 🟩
rust-images / rust-all 26m 🟩🟩
rust-move-tests 25m 🟩🟩
forge-compat-test / forge 25m 🟩🟩
cli-e2e-tests / run-cli-tests 21m 🟥🟥
run-tests-main-branch 13m 🟩🟩🟩
rust-lints 13m 🟩🟩
rust-build-cached-packages 10m 🟩🟩
check 7m 🟩🟩
execution-performance / test-target-determinator 6m 🟩🟩
test-target-determinator 6m 🟩🟩
general-lints 4m 🟩🟩
check-dynamic-deps 3m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 49s 🟩🟩
file_change_determinator 37s 🟩🟩🟩
file_change_determinator 26s 🟩🟩
file_change_determinator 24s 🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩
determine-docker-build-metadata 6s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 10m 7m +41%
rust-targeted-unit-tests 27m 19m +40%

settingsfeedbackdocs ⋅ learn more about trunk.io

@heliuchuan heliuchuan changed the base branch from main to aptos-release-v1.13 June 4, 2024 20:38
@heliuchuan heliuchuan changed the title Cherrypickkeylesssim Cherry-pick keyless txn simulation fix in v1.13 Jun 4, 2024
@heliuchuan heliuchuan marked this pull request as ready for review June 4, 2024 20:40
@sherry-x sherry-x enabled auto-merge (squash) June 4, 2024 21:06

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Forge suite compat success on c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 49626962a437cb48ba40f0543c35ac1b563fce3b

Compatibility test results for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 49626962a437cb48ba40f0543c35ac1b563fce3b (PR)
1. Check liveness of validators at old version: c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e
compatibility::simple-validator-upgrade::liveness-check : committed: 6820.485749340383 txn/s, latency: 4822.640631298879 ms, (p50: 4800 ms, p90: 8100 ms, p99: 8700 ms), latency samples: 248060
2. Upgrading first Validator to new version: 49626962a437cb48ba40f0543c35ac1b563fce3b
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3348.654080473263 txn/s, latency: 9283.961729636547 ms, (p50: 9500 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 139220
3. Upgrading rest of first batch to new version: 49626962a437cb48ba40f0543c35ac1b563fce3b
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3339.9623715332773 txn/s, latency: 9302.882019562716 ms, (p50: 9400 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 139040
4. upgrading second batch to new version: 49626962a437cb48ba40f0543c35ac1b563fce3b
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4999.714896707967 txn/s, latency: 6507.558829973707 ms, (p50: 5400 ms, p90: 10000 ms, p99: 12600 ms), latency samples: 182560
5. check swarm health
Compatibility test for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 49626962a437cb48ba40f0543c35ac1b563fce3b passed
Test Ok

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Forge suite realistic_env_max_load success on 49626962a437cb48ba40f0543c35ac1b563fce3b

two traffics test: inner traffic : committed: 7686.1328422374645 txn/s, latency: 5070.3696007400795 ms, (p50: 4800 ms, p90: 6500 ms, p99: 9600 ms), latency samples: 3340180
two traffics test : committed: 100.08481403947295 txn/s, latency: 2047.316091954023 ms, (p50: 1900 ms, p90: 2300 ms, p99: 6700 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.220, avg: 0.204", "QsPosToProposal: max: 0.280, avg: 0.260", "ConsensusProposalToOrdered: max: 0.457, avg: 0.420", "ConsensusOrderedToCommit: max: 0.387, avg: 0.373", "ConsensusProposalToCommit: max: 0.812, avg: 0.792"]
Max round gap was 1 [limit 4] at version 1577198. Max no progress secs was 4.5989428 [limit 15] at version 1577198.
Test Ok

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Forge suite framework_upgrade success on c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 49626962a437cb48ba40f0543c35ac1b563fce3b

Compatibility test results for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 49626962a437cb48ba40f0543c35ac1b563fce3b (PR)
Upgrade the nodes to version: 49626962a437cb48ba40f0543c35ac1b563fce3b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1194.2770365955357 txn/s, submitted: 1196.4639566405742 txn/s, failed submission: 2.18692004503852 txn/s, expired: 2.18692004503852 txn/s, latency: 2626.406528108405 ms, (p50: 2100 ms, p90: 4200 ms, p99: 8000 ms), latency samples: 109220
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1205.7154539006071 txn/s, submitted: 1208.7525205351174 txn/s, failed submission: 3.0370666345103454 txn/s, expired: 3.0370666345103454 txn/s, latency: 2597.887957760124 ms, (p50: 2000 ms, p90: 4700 ms, p99: 8400 ms), latency samples: 103220
5. check swarm health
Compatibility test for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 49626962a437cb48ba40f0543c35ac1b563fce3b passed
Upgrade the remaining nodes to version: 49626962a437cb48ba40f0543c35ac1b563fce3b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1151.491565569284 txn/s, submitted: 1153.3095905395926 txn/s, failed submission: 1.8180249703087172 txn/s, expired: 1.8180249703087172 txn/s, latency: 2707.66036116045 ms, (p50: 2100 ms, p90: 5000 ms, p99: 7200 ms), latency samples: 101340
Test Ok

@sherry-x sherry-x merged commit 78e553d into aptos-release-v1.13 Jun 4, 2024
42 of 45 checks passed
@sherry-x sherry-x deleted the cherrypickkeylesssim branch June 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants