Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Move Compiler to components list, reorder sections to make more sense #14384

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

brmataptos
Copy link
Contributor

Description

Add Move Compiler to the list of Components.

Reorder sections to be more efficient: put all checklists at the
bottom, since they take a lot of vertical space and are not so useful
for the reviewer.

How Has This Been Tested?

No idea how to do that.

Key Areas to Review

Consider whether this ordering is better than putting useless checklists at the top.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (Github template)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@brmataptos brmataptos requested a review from a team as a code owner August 22, 2024 04:53
Copy link

trunk-io bot commented Aug 22, 2024

⏱️ 3m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 2m 🟩
check-dynamic-deps 37s 🟩
semgrep/ci 25s 🟩
rust-cargo-deny 16s 🟥
file_change_determinator 11s 🟩
file_change_determinator 10s 🟩
permission-check 4s 🟩
permission-check 4s 🟩
permission-check 3s 🟩
permission-check 2s 🟩
general-lints 1s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
general-lints 1s 2m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@wrwg wrwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, agree that this is better, still need @gedigi to agree though.

@brmataptos brmataptos enabled auto-merge (squash) September 21, 2024 22:13

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 02baa6079d1b5813395095a97bfab2db56b784ad

two traffics test: inner traffic : committed: 14499.49 txn/s, latency: 2740.31 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5513100
two traffics test : committed: 100.08 txn/s, latency: 1759.50 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 10300 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.237, avg: 0.222", "QsPosToProposal: max: 1.095, avg: 1.066", "ConsensusProposalToOrdered: max: 0.315, avg: 0.290", "ConsensusOrderedToCommit: max: 0.412, avg: 0.403", "ConsensusProposalToCommit: max: 0.701, avg: 0.692"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 34115 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.61s no progress at version 3042782 (avg 8.61s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 25a081116546670e62ca927ba90478de78557056 ==> 02baa6079d1b5813395095a97bfab2db56b784ad

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 02baa6079d1b5813395095a97bfab2db56b784ad (PR)
Upgrade the nodes to version: 02baa6079d1b5813395095a97bfab2db56b784ad
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1193.81 txn/s, submitted: 1195.57 txn/s, failed submission: 1.76 txn/s, expired: 1.76 txn/s, latency: 2535.08 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5500 ms), latency samples: 108320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1220.13 txn/s, submitted: 1222.55 txn/s, failed submission: 2.42 txn/s, expired: 2.42 txn/s, latency: 2453.07 ms, (p50: 2300 ms, p70: 2500, p90: 3600 ms, p99: 4800 ms), latency samples: 110800
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 02baa6079d1b5813395095a97bfab2db56b784ad passed
Upgrade the remaining nodes to version: 02baa6079d1b5813395095a97bfab2db56b784ad
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1159.10 txn/s, submitted: 1160.95 txn/s, failed submission: 1.85 txn/s, expired: 1.85 txn/s, latency: 2716.24 ms, (p50: 2500 ms, p70: 3000, p90: 4100 ms, p99: 5700 ms), latency samples: 100040
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> 02baa6079d1b5813395095a97bfab2db56b784ad

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 02baa6079d1b5813395095a97bfab2db56b784ad (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 14372.19 txn/s, latency: 2256.83 ms, (p50: 2100 ms, p70: 2200, p90: 2400 ms, p99: 7900 ms), latency samples: 547140
2. Upgrading first Validator to new version: 02baa6079d1b5813395095a97bfab2db56b784ad
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8134.08 txn/s, latency: 3537.08 ms, (p50: 3900 ms, p70: 4100, p90: 4200 ms, p99: 4300 ms), latency samples: 150820
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7389.86 txn/s, latency: 3956.77 ms, (p50: 4200 ms, p70: 4200, p90: 4300 ms, p99: 5500 ms), latency samples: 277920
3. Upgrading rest of first batch to new version: 02baa6079d1b5813395095a97bfab2db56b784ad
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7554.64 txn/s, latency: 3706.38 ms, (p50: 4000 ms, p70: 4200, p90: 4400 ms, p99: 4500 ms), latency samples: 140980
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7571.24 txn/s, latency: 4227.84 ms, (p50: 4400 ms, p70: 4500, p90: 6000 ms, p99: 6200 ms), latency samples: 251160
4. upgrading second batch to new version: 02baa6079d1b5813395095a97bfab2db56b784ad
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11752.60 txn/s, latency: 2300.58 ms, (p50: 2400 ms, p70: 2600, p90: 2800 ms, p99: 3000 ms), latency samples: 205640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10061.18 txn/s, latency: 2712.59 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3600 ms), latency samples: 379400
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 02baa6079d1b5813395095a97bfab2db56b784ad passed
Test Ok

@brmataptos brmataptos merged commit ac60da1 into main Sep 23, 2024
85 of 92 checks passed
@brmataptos brmataptos deleted the brm-pull-template branch September 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants