Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFT Metadata Crawler] Asset Uploader API #14843

Open
wants to merge 2 commits into
base: justin/asset-uploader-worker
Choose a base branch
from

Conversation

just-in-chang
Copy link
Contributor

@just-in-chang just-in-chang commented Oct 2, 2024

Description

Implementation of the Asset Uploader API.

Design: https://www.notion.so/aptoslabs/WIP-Asset-Uploader-cb33138051324d1fa03115ef1b55ed0b

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@just-in-chang just-in-chang requested review from jillxuu and a team October 2, 2024 11:10
Copy link

trunk-io bot commented Oct 2, 2024

⏱️ 1h 39m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 13m 🟩🟩🟩🟩 (+4 more)
check-dynamic-deps 13m 🟩🟩🟩🟩🟩 (+4 more)
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 6m
rust-move-tests 6m
general-lints 4m 🟩🟩🟩🟩🟩 (+4 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+4 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+4 more)
rust-move-tests 1m
permission-check 35s 🟩🟩🟩🟩🟩 (+4 more)
permission-check 25s 🟩🟩🟩🟩🟩 (+4 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

},
Error {
status_code: u16,
error_mwssage: String,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field error_mwssage contains a typo and should be corrected to error_message. This change will ensure consistency throughout the codebase and prevent potential issues when accessing or referencing this field in other parts of the application.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@just-in-chang just-in-chang requested a review from a team as a code owner October 3, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant