Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cp][aptos-release-v1.21] [qs] tolerate block timestamp being updated asynchronously #14864

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[cp][aptos-release-v1.21] [qs] tolerate block timestamp being updated asynchronously #14864

merged 1 commit into from
Oct 4, 2024
+5 −14

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 3, 2024

Backport

This will backport the following commits from main to aptos-release-v1.21:

Questions ?

Please refer to the Backport tool documentation

[qs] tolerate block timestamp being updated asynchronously
3d3593c 
In previous commit, we move timestamp update to async callback to ensure the consistency between mempool, qs and consensus.
However it introduces the race of timestamp can be updated by sync_to first then async callback and violates the assertion.

(cherry picked from commit 41e82f7)
@trunk-io Trunk.io
Copy link

trunk-io bot commented Oct 3, 2024 •
edited
Loading

⏱️ 49m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 22m 🟩 
rust-doc-tests 5m 🟩 
test-target-determinator 5m 🟩 
execution-performance / test-target-determinator 4m 🟩 
check 4m 🟩 
check-dynamic-deps 3m 🟩 
rust-move-tests 2m 🟩 
rust-cargo-deny 2m 🟩 
fetch-last-released-docker-image-tag 2m 🟩 
general-lints 46s 🟩 
semgrep/ci 23s 🟩 
file_change_determinator 13s 🟩 
file_change_determinator 11s 🟩 
execution-performance / single-node-performance 11s 🟩 
Backport PR 4s 🟥 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +128%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Merged
@zekun000 zekun000 enabled auto-merge (rebase) October 4, 2024 16:40
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Oct 4, 2024

✅ Forge suite realistic_env_max_load success on 3d3593c517ca765d94aee265847b53a45e528d2e

two traffics test: inner traffic : committed: 13429.38 txn/s, latency: 2961.79 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 4200 ms), latency samples: 5106400
two traffics test : committed: 99.92 txn/s, latency: 2712.88 ms, (p50: 2500 ms, p70: 2700, p90: 3100 ms, p99: 10500 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.234, avg: 0.222", "QsPosToProposal: max: 0.313, avg: 0.261", "ConsensusProposalToOrdered: max: 0.325, avg: 0.303", "ConsensusOrderedToCommit: max: 0.504, avg: 0.472", "ConsensusProposalToCommit: max: 0.808, avg: 0.775"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 2444381 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.42s no progress at version 2444379 (avg 8.42s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Oct 4, 2024

✅ Forge suite framework_upgrade success on 5a0ae460c37efe85a16a4d8eb27022828c66f44c ==> 3d3593c517ca765d94aee265847b53a45e528d2e

Compatibility test results for 5a0ae460c37efe85a16a4d8eb27022828c66f44c ==> 3d3593c517ca765d94aee265847b53a45e528d2e (PR)
Upgrade the nodes to version: 3d3593c517ca765d94aee265847b53a45e528d2e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1299.75 txn/s, submitted: 1302.40 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2650.38 ms, (p50: 2400 ms, p70: 2700, p90: 4700 ms, p99: 6900 ms), latency samples: 108020
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1284.18 txn/s, submitted: 1286.08 txn/s, failed submission: 1.89 txn/s, expired: 1.89 txn/s, latency: 2528.50 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5200 ms), latency samples: 108560
5. check swarm health
Compatibility test for 5a0ae460c37efe85a16a4d8eb27022828c66f44c ==> 3d3593c517ca765d94aee265847b53a45e528d2e passed
Upgrade the remaining nodes to version: 3d3593c517ca765d94aee265847b53a45e528d2e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1315.69 txn/s, submitted: 1317.52 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2551.17 ms, (p50: 2400 ms, p70: 2700, p90: 4100 ms, p99: 5700 ms), latency samples: 115460
Test Ok

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Oct 4, 2024

✅ Forge suite compat success on 5a0ae460c37efe85a16a4d8eb27022828c66f44c ==> 3d3593c517ca765d94aee265847b53a45e528d2e

Compatibility test results for 5a0ae460c37efe85a16a4d8eb27022828c66f44c ==> 3d3593c517ca765d94aee265847b53a45e528d2e (PR)
1. Check liveness of validators at old version: 5a0ae460c37efe85a16a4d8eb27022828c66f44c
compatibility::simple-validator-upgrade::liveness-check : committed: 11256.40 txn/s, latency: 2504.47 ms, (p50: 1900 ms, p70: 2100, p90: 2400 ms, p99: 25100 ms), latency samples: 457440
2. Upgrading first Validator to new version: 3d3593c517ca765d94aee265847b53a45e528d2e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7594.30 txn/s, latency: 3724.69 ms, (p50: 4200 ms, p70: 4400, p90: 4600 ms, p99: 4700 ms), latency samples: 140240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7394.01 txn/s, latency: 4353.43 ms, (p50: 4600 ms, p70: 4800, p90: 6000 ms, p99: 6400 ms), latency samples: 242520
3. Upgrading rest of first batch to new version: 3d3593c517ca765d94aee265847b53a45e528d2e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3259.01 txn/s, latency: 8105.89 ms, (p50: 9900 ms, p70: 10400, p90: 11500 ms, p99: 11700 ms), latency samples: 58940
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4700.54 txn/s, latency: 6883.92 ms, (p50: 7300 ms, p70: 7400, p90: 8400 ms, p99: 8700 ms), latency samples: 184460
4. upgrading second batch to new version: 3d3593c517ca765d94aee265847b53a45e528d2e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10656.74 txn/s, latency: 2541.23 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 3400 ms), latency samples: 188580
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9283.65 txn/s, latency: 2827.70 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 8000 ms), latency samples: 380180
5. check swarm health
Compatibility test for 5a0ae460c37efe85a16a4d8eb27022828c66f44c ==> 3d3593c517ca765d94aee265847b53a45e528d2e passed
Test Ok

@zekun000 zekun000 merged commit 46bf19e into aptos-release-v1.21 Oct 4, 2024
49 checks passed
@zekun000 zekun000 deleted the backport/aptos-release-v1.21/pr-14861 branch October 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibalajiarun ibalajiarun ibalajiarun approved these changes

@zekun000 zekun000 zekun000 approved these changes

@bchocho bchocho Awaiting requested review from bchocho bchocho is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 is a code owner

@gelash gelash Awaiting requested review from gelash gelash is a code owner

Assignees

@thepomeranian thepomeranian

Labels
cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibalajiarun @zekun000 @thepomeranian