Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move-vm] Make bytecode version v7 the default #14876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[move-vm] Make bytecode version v7 the default #14876

wants to merge 1 commit into from
+119 −122

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Oct 4, 2024

Description

We could not do that before because mainnet did not support v7 yet, but that has changed now.

How Has This Been Tested?

Existing tests

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

@trunk-io Trunk.io
Copy link

trunk-io bot commented Oct 4, 2024 •
edited
Loading

⏱️ 2h 17m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 43m 🟩 🟥 
rust-move-unit-coverage 12m 🟩 
rust-move-unit-coverage 11m 🟩 
rust-move-tests 10m 🟩 
rust-move-tests 10m 🟩 
execution-performance / test-target-determinator 9m 🟩 🟩 
test-target-determinator 9m 🟩 🟩 
check 7m 🟩 🟩 
rust-doc-tests 5m 🟩 
rust-doc-tests 5m 🟩 
rust-cargo-deny 5m ⬜ 🟩 🟩 
check-dynamic-deps 4m 🟩 🟩 🟩 
fetch-last-released-docker-image-tag 3m 🟩 🟩 
general-lints 1m 🟩 🟩 🟩 
semgrep/ci 1m 🟩 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@wrwg Graphite App
Copy link
Contributor Author

wrwg commented Oct 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite Graphite

@wrwg wrwg enabled auto-merge (squash) October 4, 2024 20:20
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.8%. Comparing base (d9c7970) to head (fdec5ba).

Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #14876       +/-   ##
===========================================
- Coverage    72.6%    59.8%    -12.9%     
===========================================
  Files        2400      853     -1547     
  Lines      485208   208243   -276965     
===========================================
- Hits       352656   124530   -228126     
+ Misses     132552    83713    -48839

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@wrwg
[move-vm] Make bytecode version v7 the default
fdec5ba 
We could not do that before because mainnet did not support v7 yet, but that has changed now.
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fdec5baf95e75c463fba37ab15048dff86d4bbc4

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fdec5baf95e75c463fba37ab15048dff86d4bbc4 (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 15840.41 txn/s, latency: 2130.59 ms, (p50: 2100 ms, p70: 2200, p90: 2600 ms, p99: 3500 ms), latency samples: 515340
2. Upgrading first Validator to new version: fdec5baf95e75c463fba37ab15048dff86d4bbc4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6996.75 txn/s, latency: 4004.34 ms, (p50: 4400 ms, p70: 4800, p90: 5000 ms, p99: 5000 ms), latency samples: 134260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6150.96 txn/s, latency: 5226.91 ms, (p50: 5300 ms, p70: 5600, p90: 7400 ms, p99: 7700 ms), latency samples: 209740
3. Upgrading rest of first batch to new version: fdec5baf95e75c463fba37ab15048dff86d4bbc4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6818.60 txn/s, latency: 4106.87 ms, (p50: 4300 ms, p70: 4800, p90: 5500 ms, p99: 5900 ms), latency samples: 129200
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7162.18 txn/s, latency: 4488.17 ms, (p50: 4700 ms, p70: 5000, p90: 6200 ms, p99: 6600 ms), latency samples: 242400
4. upgrading second batch to new version: fdec5baf95e75c463fba37ab15048dff86d4bbc4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11553.23 txn/s, latency: 2307.90 ms, (p50: 2500 ms, p70: 2600, p90: 2800 ms, p99: 2900 ms), latency samples: 205980
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10939.60 txn/s, latency: 2831.90 ms, (p50: 2700 ms, p70: 2900, p90: 4100 ms, p99: 5100 ms), latency samples: 358100
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fdec5baf95e75c463fba37ab15048dff86d4bbc4 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

✅ Forge suite realistic_env_max_load success on fdec5baf95e75c463fba37ab15048dff86d4bbc4

two traffics test: inner traffic : committed: 13181.74 txn/s, latency: 3017.99 ms, (p50: 2800 ms, p70: 3000, p90: 3300 ms, p99: 5100 ms), latency samples: 5012300
two traffics test : committed: 99.91 txn/s, latency: 2831.69 ms, (p50: 2500 ms, p70: 2700, p90: 3300 ms, p99: 10100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.236, avg: 0.222", "QsPosToProposal: max: 0.296, avg: 0.239", "ConsensusProposalToOrdered: max: 0.310, avg: 0.303", "ConsensusOrderedToCommit: max: 0.512, avg: 0.478", "ConsensusProposalToCommit: max: 0.818, avg: 0.781"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 1992614 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.55s no progress at version 1992612 (avg 6.95s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fdec5baf95e75c463fba37ab15048dff86d4bbc4

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fdec5baf95e75c463fba37ab15048dff86d4bbc4 (PR)
Upgrade the nodes to version: fdec5baf95e75c463fba37ab15048dff86d4bbc4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1609.91 txn/s, submitted: 1611.26 txn/s, failed submission: 1.35 txn/s, expired: 1.35 txn/s, latency: 2420.58 ms, (p50: 2300 ms, p70: 2400, p90: 3900 ms, p99: 5300 ms), latency samples: 119000
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1130.88 txn/s, submitted: 1133.10 txn/s, failed submission: 2.21 txn/s, expired: 2.21 txn/s, latency: 2562.09 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5700 ms), latency samples: 102140
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fdec5baf95e75c463fba37ab15048dff86d4bbc4 passed
Upgrade the remaining nodes to version: fdec5baf95e75c463fba37ab15048dff86d4bbc4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1184.20 txn/s, submitted: 1188.49 txn/s, failed submission: 4.29 txn/s, expired: 4.29 txn/s, latency: 2492.29 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5600 ms), latency samples: 104900
Test Ok

brmataptos
brmataptos reviewed Oct 5, 2024
View reviewed changes
third_party/move/move-binary-format/src/file_format_common.rs
@@ -518,9 +518,9 @@ pub const VERSION_8: u32 = 8;
pub const VERSION_MAX: u32 = VERSION_7;

/// Mark which version is the default version. This is the version used by default by tools like
/// the compiler. Notice that this version might be different than the one supported on nodes.
/// the compiler. Notice that this version might be different from the one supported on nodes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: "different than" is perfectly acceptable in American English, although it seems that "different from" is preferred in writing. Wasn't really worth changing, but not worth arguing about, either.

Brits randomly use "different to" which always sounds very wrong to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brmataptos brmataptos brmataptos left review comments

@runtian-zhou runtian-zhou runtian-zhou approved these changes

@rahxephon89 rahxephon89 rahxephon89 approved these changes

@vgao1996 vgao1996 Awaiting requested review from vgao1996

@ziaptos ziaptos Awaiting requested review from ziaptos

@georgemitenkov georgemitenkov Awaiting requested review from georgemitenkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrwg @runtian-zhou @rahxephon89 @brmataptos