Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move][framework] Enable building framework with move-2 #14877

Open
wants to merge 1 commit into
base: igor/native_compare
Choose a base branch
from

Conversation

igor-aptos
Copy link
Contributor

To be landed for the release we are ready to do so.

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 4, 2024

⏱️ 48m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-unit-coverage 11m 🟩
rust-move-tests 10m 🟥
rust-move-unit-coverage 10m 🟩
rust-move-tests 10m 🟥
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩
general-lints 56s 🟩🟩
semgrep/ci 42s 🟩🟩
file_change_determinator 22s 🟩🟩
permission-check 8s 🟩🟩
permission-check 7s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.8%. Comparing base (18ba714) to head (402d517).

Files with missing lines Patch % Lines
aptos-move/framework/src/aptos.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           igor/native_compare   #14877   +/-   ##
====================================================
  Coverage                 59.8%    59.8%           
====================================================
  Files                      856      856           
  Lines                   208499   208499           
====================================================
  Hits                    124796   124796           
  Misses                   83703    83703           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

To be landed for the release we are ready to do so.
@igor-aptos igor-aptos force-pushed the igor/enable_move_2_for_framework branch from 1e11c6a to 402d517 Compare October 4, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant