Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off move coverage #14995

Merged
merged 2 commits into from
Oct 17, 2024
Merged

turn off move coverage #14995

merged 2 commits into from
Oct 17, 2024

Conversation

sausagee
Copy link
Contributor

Description

Disable Move code coverage workflow in pull request.

How Has This Been Tested?

CI

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify): CI

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@sausagee sausagee requested a review from a team as a code owner October 17, 2024 16:39
Copy link

trunk-io bot commented Oct 17, 2024

⏱️ 1h 24m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-e2e-test / forge 15m 🟩
forge-e2e-test / forge 12m 🟩
execution-performance / test-target-determinator 10m 🟩🟩
test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
check-dynamic-deps 3m 🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 58s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sausagee sausagee requested review from rahxephon89 and wrwg and removed request for a team October 17, 2024 16:39
@sausagee sausagee enabled auto-merge (squash) October 17, 2024 17:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> f410ba0db34170bbc8186a656e4dfe94a5f89040

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> f410ba0db34170bbc8186a656e4dfe94a5f89040 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 11009.59 txn/s, latency: 2939.42 ms, (p50: 2200 ms, p70: 2400, p90: 6300 ms, p99: 16300 ms), latency samples: 380200
2. Upgrading first Validator to new version: f410ba0db34170bbc8186a656e4dfe94a5f89040
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5206.00 txn/s, latency: 5297.97 ms, (p50: 5400 ms, p70: 5800, p90: 6200 ms, p99: 9100 ms), latency samples: 94940
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5911.91 txn/s, latency: 5337.43 ms, (p50: 5400 ms, p70: 5600, p90: 7400 ms, p99: 7600 ms), latency samples: 201200
3. Upgrading rest of first batch to new version: f410ba0db34170bbc8186a656e4dfe94a5f89040
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6824.55 txn/s, latency: 4014.42 ms, (p50: 4600 ms, p70: 5000, p90: 5200 ms, p99: 5600 ms), latency samples: 122540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7071.23 txn/s, latency: 4533.89 ms, (p50: 4700 ms, p70: 4900, p90: 6500 ms, p99: 7000 ms), latency samples: 233860
4. upgrading second batch to new version: f410ba0db34170bbc8186a656e4dfe94a5f89040
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11314.18 txn/s, latency: 2378.80 ms, (p50: 2600 ms, p70: 2700, p90: 2800 ms, p99: 3000 ms), latency samples: 200260
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9562.84 txn/s, latency: 3223.01 ms, (p50: 2700 ms, p70: 2800, p90: 4000 ms, p99: 10600 ms), latency samples: 384760
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> f410ba0db34170bbc8186a656e4dfe94a5f89040 passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> f410ba0db34170bbc8186a656e4dfe94a5f89040

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> f410ba0db34170bbc8186a656e4dfe94a5f89040 (PR)
Upgrade the nodes to version: f410ba0db34170bbc8186a656e4dfe94a5f89040
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1254.79 txn/s, submitted: 1257.75 txn/s, failed submission: 2.95 txn/s, expired: 2.95 txn/s, latency: 2618.10 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 5800 ms), latency samples: 110480
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1146.79 txn/s, submitted: 1148.89 txn/s, failed submission: 2.11 txn/s, expired: 2.11 txn/s, latency: 2793.07 ms, (p50: 2400 ms, p70: 3000, p90: 4500 ms, p99: 6300 ms), latency samples: 98040
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> f410ba0db34170bbc8186a656e4dfe94a5f89040 passed
Upgrade the remaining nodes to version: f410ba0db34170bbc8186a656e4dfe94a5f89040
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1150.36 txn/s, submitted: 1151.97 txn/s, failed submission: 1.61 txn/s, expired: 1.61 txn/s, latency: 2725.28 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 6400 ms), latency samples: 100280
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on f410ba0db34170bbc8186a656e4dfe94a5f89040

two traffics test: inner traffic : committed: 14013.66 txn/s, latency: 2837.40 ms, (p50: 2700 ms, p70: 2700, p90: 3200 ms, p99: 6300 ms), latency samples: 5328300
two traffics test : committed: 100.09 txn/s, latency: 2439.78 ms, (p50: 1600 ms, p70: 2100, p90: 4900 ms, p99: 7900 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.232, avg: 0.218", "QsPosToProposal: max: 1.108, avg: 0.803", "ConsensusProposalToOrdered: max: 0.320, avg: 0.301", "ConsensusOrderedToCommit: max: 0.498, avg: 0.468", "ConsensusProposalToCommit: max: 0.800, avg: 0.768"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.88s no progress at version 2748271 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.56s no progress at version 2748269 (avg 8.56s) [limit 15].
Test Ok

@sausagee sausagee merged commit 9b03063 into main Oct 17, 2024
43 of 46 checks passed
@sausagee sausagee deleted the move_cov_off branch October 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants