Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] fix processor sdk integration #14996

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented Oct 17, 2024

Description

Few issues found from the canary of #14924

  • Processor SDK metrics query needs to result in a single series. So take the max rather than max by (bla)
  • Deployer should always pull the latest image. It defaults to IfNotPresent, which means new deployer profiles will not get picked up

How Has This Been Tested?

Canary on this PR, which is possible since there are no workflow changes. Use the new forge_indexer_sdk profile

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 17, 2024

⏱️ 53m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 4m 🟩🟩🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
semgrep/ci 1m 🟩🟩🟩
general-lints 56s 🟩🟩
file_change_determinator 28s 🟩🟩
file_change_determinator 24s 🟩🟩
execution-performance / single-node-performance 21s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rustielin rustielin added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Oct 17, 2024
@rustielin rustielin requested review from rtso and a team October 17, 2024 17:24
@rustielin rustielin marked this pull request as ready for review October 17, 2024 17:29

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@rustielin rustielin enabled auto-merge (squash) October 17, 2024 18:18

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b

two traffics test: inner traffic : committed: 11844.55 txn/s, submitted: 11844.66 txn/s, expired: 0.11 txn/s, latency: 3360.35 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 17100 ms), latency samples: 4503600
two traffics test : committed: 100.03 txn/s, latency: 2195.88 ms, (p50: 1500 ms, p70: 1700, p90: 4400 ms, p99: 10100 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.254, avg: 0.230", "QsPosToProposal: max: 1.239, avg: 1.076", "ConsensusProposalToOrdered: max: 0.353, avg: 0.338", "ConsensusOrderedToCommit: max: 0.588, avg: 0.479", "ConsensusProposalToCommit: max: 0.913, avg: 0.818"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.16s no progress at version 1834122 (avg 0.24s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.51s no progress at version 1834120 (avg 6.07s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 10312.33 txn/s, latency: 3123.47 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 28700 ms), latency samples: 416280
2. Upgrading first Validator to new version: 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6999.91 txn/s, latency: 3998.23 ms, (p50: 4600 ms, p70: 4800, p90: 5000 ms, p99: 5100 ms), latency samples: 129900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7109.18 txn/s, latency: 4392.31 ms, (p50: 4600 ms, p70: 4700, p90: 5900 ms, p99: 6300 ms), latency samples: 237360
3. Upgrading rest of first batch to new version: 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7589.38 txn/s, latency: 3598.37 ms, (p50: 4000 ms, p70: 4200, p90: 4400 ms, p99: 4400 ms), latency samples: 141420
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6911.08 txn/s, latency: 4599.40 ms, (p50: 4400 ms, p70: 4600, p90: 7400 ms, p99: 7900 ms), latency samples: 258400
4. upgrading second batch to new version: 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9281.40 txn/s, latency: 2568.91 ms, (p50: 2600 ms, p70: 2800, p90: 3000 ms, p99: 4800 ms), latency samples: 195320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9564.17 txn/s, latency: 3274.13 ms, (p50: 2700 ms, p70: 2800, p90: 7800 ms, p99: 9100 ms), latency samples: 320200
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b (PR)
Upgrade the nodes to version: 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1113.66 txn/s, submitted: 1116.30 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2684.80 ms, (p50: 2400 ms, p70: 3000, p90: 4500 ms, p99: 6900 ms), latency samples: 101320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1034.66 txn/s, submitted: 1036.43 txn/s, failed submission: 1.77 txn/s, expired: 1.77 txn/s, latency: 2910.16 ms, (p50: 2400 ms, p70: 2700, p90: 6000 ms, p99: 8700 ms), latency samples: 93420
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b passed
Upgrade the remaining nodes to version: 6bafa93c13b4da64dc3a8bf30a66b2e83c11977b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1305.98 txn/s, submitted: 1308.16 txn/s, failed submission: 2.19 txn/s, expired: 2.19 txn/s, latency: 2662.64 ms, (p50: 2400 ms, p70: 2700, p90: 4700 ms, p99: 6300 ms), latency samples: 107500
Test Ok

@rustielin rustielin merged commit 6d3a0de into main Oct 17, 2024
126 of 136 checks passed
@rustielin rustielin deleted the rustielin/indexer-forge-processor-latency-2 branch October 17, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants