[cp 1.23] fix deadlock on nested DropHelper

[msmouse]

cherry-pick #15322 to v1.23 release branch

[trunk-io]

⏱️ 3h 34m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-unit-tests	1h 27m	🟥 🟥 🟥 🟩
execution-performance / single-node-performance	27m	🟩
rust-unit-tests	19m	⬜
rust-images / rust-all	16m	🟥 🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-unit-tests	8m	⬜
rust-move-tests	8m	⬜
rust-cargo-deny	5m	🟩 🟩 🟩
test-target-determinator	5m	🟩
execution-performance / test-target-determinator	5m	🟩
rust-doc-tests	5m	🟩
check	4m	🟩
check-dynamic-deps	3m	🟩 🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	27m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on ab8c6cdd54c779b5bc8e828f413f6faf082245a3

two traffics test: inner traffic : committed: 14263.36 txn/s, latency: 2788.15 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5423220
two traffics test : committed: 100.08 txn/s, latency: 1387.00 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1800 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.045, avg: 1.614", "ConsensusProposalToOrdered: max: 0.322, avg: 0.295", "ConsensusOrderedToCommit: max: 0.361, avg: 0.350", "ConsensusProposalToCommit: max: 0.653, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.80s no progress at version 2067098 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.51s no progress at version 2067096 (avg 7.46s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> ab8c6cdd54c779b5bc8e828f413f6faf082245a3

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> ab8c6cdd54c779b5bc8e828f413f6faf082245a3 (PR)
Upgrade the nodes to version: ab8c6cdd54c779b5bc8e828f413f6faf082245a3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1253.03 txn/s, submitted: 1254.90 txn/s, failed submission: 1.87 txn/s, expired: 1.87 txn/s, latency: 2561.06 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5700 ms), latency samples: 107080
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1412.25 txn/s, submitted: 1416.94 txn/s, failed submission: 4.70 txn/s, expired: 4.70 txn/s, latency: 2100.24 ms, (p50: 1800 ms, p70: 2100, p90: 3000 ms, p99: 5700 ms), latency samples: 126300
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> ab8c6cdd54c779b5bc8e828f413f6faf082245a3 passed
Upgrade the remaining nodes to version: ab8c6cdd54c779b5bc8e828f413f6faf082245a3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1395.74 txn/s, submitted: 1398.83 txn/s, failed submission: 3.10 txn/s, expired: 3.10 txn/s, latency: 2173.00 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4900 ms), latency samples: 126180
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> ab8c6cdd54c779b5bc8e828f413f6faf082245a3

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> ab8c6cdd54c779b5bc8e828f413f6faf082245a3 (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 14125.02 txn/s, latency: 2412.39 ms, (p50: 1800 ms, p70: 2000, p90: 4200 ms, p99: 11800 ms), latency samples: 476920
2. Upgrading first Validator to new version: ab8c6cdd54c779b5bc8e828f413f6faf082245a3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7580.92 txn/s, latency: 3673.98 ms, (p50: 3800 ms, p70: 4200, p90: 5000 ms, p99: 5300 ms), latency samples: 141620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7508.11 txn/s, latency: 4285.54 ms, (p50: 4400 ms, p70: 4600, p90: 6100 ms, p99: 6200 ms), latency samples: 248020
3. Upgrading rest of first batch to new version: ab8c6cdd54c779b5bc8e828f413f6faf082245a3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 8084.52 txn/s, latency: 3553.59 ms, (p50: 4000 ms, p70: 4100, p90: 4300 ms, p99: 4500 ms), latency samples: 148080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7462.47 txn/s, latency: 4243.45 ms, (p50: 4200 ms, p70: 4300, p90: 6700 ms, p99: 7000 ms), latency samples: 244940
4. upgrading second batch to new version: ab8c6cdd54c779b5bc8e828f413f6faf082245a3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10430.60 txn/s, latency: 2674.70 ms, (p50: 2500 ms, p70: 3000, p90: 4300 ms, p99: 4800 ms), latency samples: 205520
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10250.18 txn/s, latency: 2942.47 ms, (p50: 2500 ms, p70: 2900, p90: 5700 ms, p99: 7900 ms), latency samples: 340180
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> ab8c6cdd54c779b5bc8e828f413f6faf082245a3 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs