[consensus] Remove dead code in warnings

[gregnazario]

Description

There's dead code here in the consensus code, this removes it so we don't get warnings.

[trunk-io]

⏱️ 54m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-doc-tests	6m	🟩
execution-performance / test-target-determinator	4m	🟩
test-target-determinator	4m	🟩
check	4m	🟩
rust-cargo-deny	3m	🟩 🟩
check-dynamic-deps	2m	🟩 🟩
fetch-last-released-docker-image-tag	1m	🟩
general-lints	53s	🟩 🟩
semgrep/ci	48s	🟩 🟩
file_change_determinator	20s	🟩 🟩
file_change_determinator	11s	🟩
execution-performance / single-node-performance	11s	🟩
permission-check	6s	🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on 71841e7305e3a51e4c8706d11a92bae7e0346df4

two traffics test: inner traffic : committed: 14427.33 txn/s, submitted: 14430.28 txn/s, expired: 2.95 txn/s, latency: 2739.46 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5485620
two traffics test : committed: 100.00 txn/s, latency: 1451.20 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 2900 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.608, avg: 1.506", "ConsensusProposalToOrdered: max: 0.316, avg: 0.295", "ConsensusOrderedToCommit: max: 0.412, avg: 0.393", "ConsensusProposalToCommit: max: 0.712, avg: 0.689"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.69s no progress at version 30253 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.63s no progress at version 2750454 (avg 0.63s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 71841e7305e3a51e4c8706d11a92bae7e0346df4

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 71841e7305e3a51e4c8706d11a92bae7e0346df4 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 15852.15 txn/s, latency: 2060.31 ms, (p50: 1600 ms, p70: 1800, p90: 2400 ms, p99: 16000 ms), latency samples: 537960
2. Upgrading first Validator to new version: 71841e7305e3a51e4c8706d11a92bae7e0346df4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7072.60 txn/s, latency: 4034.70 ms, (p50: 4500 ms, p70: 4800, p90: 4900 ms, p99: 5200 ms), latency samples: 132880
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7138.22 txn/s, latency: 4640.51 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 5400 ms), latency samples: 235000
3. Upgrading rest of first batch to new version: 71841e7305e3a51e4c8706d11a92bae7e0346df4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6958.34 txn/s, latency: 4072.36 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5100 ms), latency samples: 128860
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6931.83 txn/s, latency: 4688.74 ms, (p50: 5000 ms, p70: 5100, p90: 5100 ms, p99: 5200 ms), latency samples: 236300
4. upgrading second batch to new version: 71841e7305e3a51e4c8706d11a92bae7e0346df4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 14000.81 txn/s, latency: 1946.64 ms, (p50: 2000 ms, p70: 2200, p90: 2400 ms, p99: 2900 ms), latency samples: 238120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 14130.76 txn/s, latency: 2194.15 ms, (p50: 2200 ms, p70: 2300, p90: 2400 ms, p99: 3100 ms), latency samples: 455760
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 71841e7305e3a51e4c8706d11a92bae7e0346df4 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 71841e7305e3a51e4c8706d11a92bae7e0346df4

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 71841e7305e3a51e4c8706d11a92bae7e0346df4 (PR)
Upgrade the nodes to version: 71841e7305e3a51e4c8706d11a92bae7e0346df4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1409.21 txn/s, submitted: 1413.42 txn/s, failed submission: 4.21 txn/s, expired: 4.21 txn/s, latency: 2091.03 ms, (p50: 2100 ms, p70: 2200, p90: 2700 ms, p99: 4200 ms), latency samples: 127300
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1464.96 txn/s, submitted: 1469.14 txn/s, failed submission: 4.19 txn/s, expired: 4.19 txn/s, latency: 1999.26 ms, (p50: 1800 ms, p70: 2100, p90: 2700 ms, p99: 4200 ms), latency samples: 132920
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 71841e7305e3a51e4c8706d11a92bae7e0346df4 passed
Upgrade the remaining nodes to version: 71841e7305e3a51e4c8706d11a92bae7e0346df4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 56.61 txn/s, submitted: 56.77 txn/s, failed submission: 0.16 txn/s, expired: 0.16 txn/s, latency: 5372.93 ms, (p50: 5900 ms, p70: 7100, p90: 8400 ms, p99: 9500 ms), latency samples: 50860
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking