Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounding v2 dryrun #15629

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

rounding v2 dryrun #15629

wants to merge 3 commits into from

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Dec 18, 2024

Description

Run rounding v2 impl along with v1 but ignore the v2 result.
The intention is to see v2 result on mainnet and fully apply #15071 if no issue.

How Has This Been Tested?

v2 impl is tested in #15071

Key Areas to Review

v2 impl should be as efficient as v1 and never aborts.

Type of Change

  • New feature

Which Components or Systems Does This Change Impact?

  • Validator Node

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 18, 2024

⏱️ 55m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 14m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 7m 🟥🟩🟩
check-dynamic-deps 4m 🟩🟩🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 38s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma marked this pull request as ready for review December 18, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant