[Consensus Observer] Small improvements to message metrics. #15864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 31m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
JoshLind
added
the
CICD:run-e2e-tests
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
requested review from
zekun000,
sasha8 and
ibalajiarun
as code owners
hariria
approved these changes
Feb 3, 2025
| @@ -416,13 +416,15 @@ impl ConsensusObserver { | |||
|
|
|||
| // Verify the block payload digests | |||
| if let Err(error) = block_payload.verify_payload_digests() { | |||
| // Log the error and update the invalid message counter | |||
| error!( | |||
| LogSchema::new(LogEntry::ConsensusObserver).message(&format!( | |||
There was a problem hiding this comment.
I wonder if including some information about the peer might be helpful here
There was a problem hiding this comment.
+1 will peer_network_id help here to see who's sending bad messages?
There was a problem hiding this comment.
Aah, we can derive it from the existing logs, e.g., we only have 2 streams (we know the peers), and we only process the first message. But, let me add it to the logs anyway 😄
bchocho
approved these changes
Feb 4, 2025
| @@ -416,13 +416,15 @@ impl ConsensusObserver { | |||
|
|
|||
| // Verify the block payload digests | |||
| if let Err(error) = block_payload.verify_payload_digests() { | |||
| // Log the error and update the invalid message counter | |||
| error!( | |||
| LogSchema::new(LogEntry::ConsensusObserver).message(&format!( | |||
There was a problem hiding this comment.
+1 will peer_network_id help here to see who's sending bad messages?
| @@ -1232,3 +1226,45 @@ fn update_metrics_for_ordered_block_message( | |||
| ordered_block.proof_block_info().round(), | |||
| ); | |||
| } | |||
|
|
|||
| /// Increments the dropped message counter for the given peer and message | |||
| fn update_dropped_message_counter(peer_network_id: &PeerNetworkId, message_label: &str) { | |||
There was a problem hiding this comment.
nit: should these functions be increment_ instead of update_?
There was a problem hiding this comment.
SGTM. Will update 😄
JoshLind
force-pushed
the
co_exec_pool1
branch
from
045e772 to
1d059b4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
co_exec_pool1
branch
from
1d059b4 to
ee3198f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❌ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small PR makes tiny improvements to the message metrics for consensus observer. Specifically, we: (i) add a new counter to track invalid messages; and (ii) refactor some of the logic into shared methods.
Testing Plan
Existing test infrastructure.