Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indexer-Grpc-V2] Implement filters. #15884

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[Indexer-Grpc-V2] Implement filters. #15884

merged 1 commit into from
Feb 5, 2025

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Feb 4, 2025

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@grao1991 grao1991 requested review from banool and rtso February 4, 2025 19:01
Copy link

trunk-io bot commented Feb 4, 2025

⏱️ 1h 29m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 31m 🟥🟩
check-dynamic-deps 23m 🟩🟩🟩🟩🟩 (+5 more)
rust-cargo-deny 13m 🟩🟩🟩🟩 (+4 more)
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
semgrep/ci 5m 🟩🟩🟩🟩🟩 (+5 more)
general-lints 4m 🟩🟩🟩🟩🟩 (+4 more)
file_change_determinator 2m 🟩🟩🟩🟩 (+5 more)
fetch-last-released-docker-image-tag 2m 🟩
permission-check 24s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 10s 🟩
permission-check 4s 🟩
determine-docker-build-metadata 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 24m 15m +60%

settingsfeedbackdocs ⋅ learn more about trunk.io

@grao1991 grao1991 force-pushed the grao_filter branch 3 times, most recently from 9c4b29b to 0473277 Compare February 4, 2025 21:26
@grao1991 grao1991 marked this pull request as ready for review February 4, 2025 21:27
@grao1991 grao1991 force-pushed the grao_filter branch 4 times, most recently from 78f003a to 660be15 Compare February 4, 2025 23:43
@grao1991 grao1991 enabled auto-merge (squash) February 5, 2025 05:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Forge suite realistic_env_max_load success on 7898ed603b62c1058c602e7bdd5c478c6aca7bb3

two traffics test: inner traffic : committed: 12942.03 txn/s, latency: 3070.22 ms, (p50: 2700 ms, p70: 3300, p90: 3900 ms, p99: 7600 ms), latency samples: 4920860
two traffics test : committed: 99.96 txn/s, latency: 3360.67 ms, (p50: 2800 ms, p70: 3500, p90: 4900 ms, p99: 15900 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.663, avg: 0.383", "ConsensusProposalToOrdered: max: 0.321, avg: 0.313", "ConsensusOrderedToCommit: max: 0.905, avg: 0.622", "ConsensusProposalToCommit: max: 1.216, avg: 0.935"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 45256 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.83s no progress at version 5582150 (avg 0.78s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Forge suite compat success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 7898ed603b62c1058c602e7bdd5c478c6aca7bb3

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 7898ed603b62c1058c602e7bdd5c478c6aca7bb3 (PR)
1. Check liveness of validators at old version: 255673e8f2757ed8634a7d65d7aca11de7016cde
compatibility::simple-validator-upgrade::liveness-check : committed: 12220.90 txn/s, latency: 2625.77 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 4200 ms), latency samples: 404920
2. Upgrading first Validator to new version: 7898ed603b62c1058c602e7bdd5c478c6aca7bb3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3422.45 txn/s, latency: 8730.88 ms, (p50: 9300 ms, p70: 10400, p90: 11100 ms, p99: 11300 ms), latency samples: 76200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3402.84 txn/s, latency: 10131.15 ms, (p50: 11100 ms, p70: 11300, p90: 11400 ms, p99: 11600 ms), latency samples: 128100
3. Upgrading rest of first batch to new version: 7898ed603b62c1058c602e7bdd5c478c6aca7bb3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3161.67 txn/s, latency: 9262.11 ms, (p50: 10000 ms, p70: 10900, p90: 11700 ms, p99: 12000 ms), latency samples: 71500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3019.31 txn/s, latency: 11079.69 ms, (p50: 12300 ms, p70: 12500, p90: 13000 ms, p99: 13200 ms), latency samples: 115900
4. upgrading second batch to new version: 7898ed603b62c1058c602e7bdd5c478c6aca7bb3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6134.66 txn/s, latency: 4968.44 ms, (p50: 5800 ms, p70: 6200, p90: 6400 ms, p99: 6600 ms), latency samples: 114900
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6163.24 txn/s, latency: 5548.45 ms, (p50: 6000 ms, p70: 6300, p90: 6400 ms, p99: 6700 ms), latency samples: 211700
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 7898ed603b62c1058c602e7bdd5c478c6aca7bb3 passed
Test Ok

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Forge suite framework_upgrade success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 7898ed603b62c1058c602e7bdd5c478c6aca7bb3

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 7898ed603b62c1058c602e7bdd5c478c6aca7bb3 (PR)
Upgrade the nodes to version: 7898ed603b62c1058c602e7bdd5c478c6aca7bb3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1722.23 txn/s, submitted: 1729.72 txn/s, failed submission: 7.49 txn/s, expired: 7.49 txn/s, latency: 1630.86 ms, (p50: 1500 ms, p70: 1800, p90: 2300 ms, p99: 3300 ms), latency samples: 156300
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1733.37 txn/s, submitted: 1737.85 txn/s, failed submission: 4.48 txn/s, expired: 4.48 txn/s, latency: 1698.28 ms, (p50: 1500 ms, p70: 1800, p90: 2500 ms, p99: 3300 ms), latency samples: 154640
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 7898ed603b62c1058c602e7bdd5c478c6aca7bb3 passed
Upgrade the remaining nodes to version: 7898ed603b62c1058c602e7bdd5c478c6aca7bb3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 907.18 txn/s, submitted: 910.51 txn/s, failed submission: 3.34 txn/s, expired: 3.34 txn/s, latency: 3203.72 ms, (p50: 2100 ms, p70: 2600, p90: 11400 ms, p99: 13400 ms), latency samples: 81562
Test Ok

@grao1991 grao1991 merged commit 25d42e5 into main Feb 5, 2025
79 of 88 checks passed
@grao1991 grao1991 deleted the grao_filter branch February 5, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants