Add Support to submit bcs serialized transactions #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
approved these changes
Apr 20, 2023
banool
approved these changes
Apr 21, 2023
0xmaayan
force-pushed
the
add_bcs_txn_support
branch
from
85f2a0d to
3698a5f
Compare
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
signAndSubmitBCSTransactionmethod to thewallet-adapter-corepackage. This function is not enforced in the wallet plugin interface and therefore will not cause any breaking changes.For wallets
Migration plan for wallets would be to support this new function in their plugin code.
For dapps
Next step would be to support the new
signAndSubmitBCSTransactionin thewallet-adapter-reactpackage.