[core] Added transaction input support for signTransaction
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardsetting
requested review from
0xmaayan,
kaw2k and
kent-white
as code owners
0xmaayan
approved these changes
Sep 6, 2024
hardsetting
force-pushed
the
gabriele/sign_transaction_with_input
branch
from
fb9f3ec to
606f23e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a PR series to enable transaction input when using
signTransactionsignTransactionwallet-standard#13Previously, the only supported input type was an AnyRawTransaction instance.
The problem with this is that we're requiring the dapp to generate the transaction (and possibly payload) right before calling signTransaction.
This requires async calls which don't play well with certain browsers and popups.