Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React as a dependency in wallet-adapter-react package #46

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Add React as a dependency in wallet-adapter-react package #46

merged 2 commits into from
Jan 10, 2023

Conversation

0xmaayan
Copy link
Collaborator

For some reason React was listed as a peerDependency and it can ends up with React package not being installed in node_modules - if it is not there, pnpm takes the references to whatever it has in the cache, and if it doesn't find it, the package doesnt know where to take it from and you end up with this error

image

This PR adds react to the dependencies array (where it should be).

Before
Screen Shot 2023-01-10 at 4 18 28 PM

After
Screen Shot 2023-01-10 at 4 18 57 PM

gregnazario
gregnazario approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! now it finally works properly locally

@0xmaayan 0xmaayan merged commit 552d255 into main Jan 10, 2023
@0xmaayan 0xmaayan deleted the react_as_dep branch January 10, 2023 16:12
@gregnazario gregnazario mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario approved these changes

@banool banool Awaiting requested review from banool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmaayan @gregnazario