Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Loadable wallet connection for mui-design #86

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fix Loadable wallet connection for mui-design #86

merged 2 commits into from
Feb 8, 2023

Conversation

scottphc
Copy link
Contributor

@scottphc scottphc commented Feb 8, 2023

  • Fix Loadable wallet connection for mui-design
  • Suppress optional dependency warnings for next.js project:

The warning is:

@aptos-labs/wallet-adapter-nextjs-example:dev: warn  - ../../node_modules/.pnpm/@blocto+sdk@0.3.5_aptos@1.4.0/node_modules/@blocto/sdk/dist/blocto-sdk.umd.js
@aptos-labs/wallet-adapter-nextjs-example:dev: Module not found: Can't resolve '@solana/web3.js' in '/Users/scott/Documents/portto/aptos/aptos-labs-aptos-wallet-adapter/node_modules/.pnpm/@blocto+sdk@0.3.5_aptos@1.4.0/node_modules/@blocto/sdk/dist'

Reference: vercel/next.js#11511 (comment)

@scottphc scottphc requested a review from 0xmaayan as a code owner February 8, 2023 08:07
@0xmaayan 0xmaayan merged commit 2678efe into aptos-labs:main Feb 8, 2023
@scottphc scottphc deleted the fix/mui-design-connect branch February 9, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottphc @0xmaayan