Add surf option to boilerplate template #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
reviewed
Oct 3, 2024
templates/boilerplate-template/frontend/view-functions-with-surf/getMessageContent.ts
Outdated
Show resolved
Hide resolved
0xmaayan
reviewed
Oct 4, 2024
Co-authored-by: Maayan <maayan@aptoslabs.com>
Co-authored-by: Maayan <maayan@aptoslabs.com>
Co-authored-by: Maayan <maayan@aptoslabs.com>
0xaptosj
force-pushed
the
j/add-surf-option
branch
from
213669e to
ac5f23a
Compare
addressed |
0xmaayan
reviewed
Oct 8, 2024
| throw new Error("Unsupported framework"); | ||
| } | ||
|
|
||
| if (selection.useSurf) { |
There was a problem hiding this comment.
any reason not to add this check before entering the function? https://github.com/aptos-labs/create-aptos-dapp/pull/246/files#diff-0594d46782df78830c5efe0fa4abb36cbf22c918dc182ccc8f3cf75fdee908e7R87
There was a problem hiding this comment.
we need to delete file if not using surf
0xmaayan
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing surf to the boilerplate template.
Tested locally on both vite and nextjs templates.