Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: want to improve country guide app i wll almost renew the Ui #852 #940

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

nishant0708
Copy link
Contributor

@nishant0708 nishant0708 commented Jul 7, 2024

Title and Issue number

Title : Updated Ui Of Country Guide Fully Make it professional

Issue No. :#852

Code Stack : mern

Close #852

Video (mandatory)

Screen.Recording.2024-07-07.185608.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have gone through the contributing.md file before contributing

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a GSSOC'24 contributor
  • I'm a SSOC'24 contributor

Copy link
Contributor

github-actions bot commented Jul 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit 25e8bed
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/66a0c1cb405d2e0008269346
😎 Deploy Preview https://deploy-preview-940--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nishant0708
Copy link
Contributor Author

Hey @apu52 @heysagnik Can You review This pr As promised i have updated Ui of Country Guide

@nishant0708
Copy link
Contributor Author

nishant0708 commented Jul 11, 2024

hey @apu52 @heysagnik @anuragverma108 please review this pr whenever possible

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed all of your changes & they are really good ....But I can't see any of the changes (https://deploy-preview-940--cute-quokka-b093d8.netlify.app/) in the deployed version of your PR.
So please check that .Otherwise although I will merge the pR , no changes will be shown in the website made by u

@apu52 apu52 added help wanted Extra attention is needed changesrequested labels Jul 12, 2024
@nishant0708
Copy link
Contributor Author

Hey @apu52 can you tell what changes might help?

@apu52
Copy link
Owner

apu52 commented Jul 13, 2024

Hey @apu52 can you tell what changes might help?

Actually in the Country guide Website(after your changes ) is not loading & not showing up anything. U can check that in the above link. So make sure that what the changes u have made must be shown up in the main website.

@nishant0708
Copy link
Contributor Author

Okay @apu52 I will fix it today only thanks for responding

@nishant0708
Copy link
Contributor Author

hey @apu52 i tried but nothing is working i am only getting one solution in mind that i could create one html page and host project somewhere else and everything will work fine other than this i cant find solution if you have any solution please let me know because it took alot of time i dont want it to go in waste i hope you understand what i am saying

@apu52
Copy link
Owner

apu52 commented Jul 21, 2024

hey @apu52 i tried but nothing is working i am only getting one solution in mind that i could create one html page and host project somewhere else and everything will work fine other than this i cant find solution if you have any solution please let me know because it took alot of time i dont want it to go in waste i hope you understand what i am saying

YEAH .I UNDERSATND & REALLY RESPECT YOUR EFFORTS . OKK TRY TO HOST THE PROJECT SOMEWHERE ELSE & PUT THE LINK IN THE WEBSITE & ALSO PUT THE LINK IN THE PROJECT FILE ITSELF & ALSO PLEASE MENTION IT IN THIS pr . GO AHEAD.

@nishant0708
Copy link
Contributor Author

hey @apu52 I have Done That + I have Added Folder There As well in Case Needed

@apu52
Copy link
Owner

apu52 commented Jul 24, 2024

@nishant0708
image

I can't see . Can u help me???

@nishant0708
Copy link
Contributor Author

@nishant0708 image

I can't see . Can u help me???

@apu52 sir Please Check it now i guess it should work

@apu52 apu52 merged commit 7901355 into apu52:main Jul 24, 2024
4 checks passed
@apu52
Copy link
Owner

apu52 commented Jul 24, 2024

@nishant0708 really great contributions.one of the most great contributions I have ever seen in this repo .Thanks for your valuable contribution. Hope to see more of your great contributions . All the best

@apu52
Copy link
Owner

apu52 commented Jul 24, 2024

& please don't call me Sir , I am just a student

@apu52 apu52 added enhancement New feature or request gssoc level3 and removed help wanted Extra attention is needed changesrequested labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: want to improve country guide app i wll almost renew the Ui
2 participants