-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add water quality data to site model and use it to power site filter #1076
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@yaodingyd you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 70
- 1
85% TypeScript
15% Jest Snapshot (tests)
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
Build succeeded and deployed at https://aqualink-app-1076.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request would normally not be reviewed by PullRequest because the pull request is a draft; however since a review was already requested, it is currently being reviewed by the PullRequest network. If you would like to cancel it, you can do so manually from the PullRequest dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here. I don't have any concerns with these changes, security or otherwise.
Reviewed with ❤️ by PullRequest
packages/api/src/utils/site.utils.ts
Outdated
@@ -1,3 +1,5 @@ | |||
/* eslint-disable fp/no-mutating-methods */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easy to do this inline instead of for the whole file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix #1026
/claim #1026
Add
waterQuality
tosite
model that would include list of water quality metrics.The logics to determine water quality metrics is from
aqualink-app/packages/website/src/common/SiteDetails/index.tsx
Lines 157 to 174 in 56dbb9c
which looks at
LatestData
entity (and forecast data, omitted by now) and check if they havehui
source or enoughsonde
metrics.If this is the correct direction, I can work on a follow up to remove the checks in frontend and consolidate to the backend, so we have single source of truth. This also avoid multiple data fetching to get water quality data