Fix console warnings on tests #935
Conversation
|
Build succeeded and deployed at https://aqualink-app-935.surge.sh |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 2,256
- 123
95% Jest Snapshot (tests)
3% TypeScript (tests)
1% TSX (tests)
1% TSX
<1% OtherGenerated lines of change
+ 8
- 214
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
| 1 Message | |
|---|---|
| Due to its size, this pull request will be reviewed by PullRequest staff before being sent to the reviewer network, and the team will reach out if there are any concerns. After this pull request is sent to the network, please be aware that it will likely have a longer turnaround time and require multiple passes from our reviewers. |
There was a problem hiding this comment.
@echaidemenos there are still errors when looking at the tests in
https://github.com/aqualinkorg/aqualink-app/actions/runs/6497769899/job/17647592203?pr=935
There was a problem hiding this comment.
Great work here. I don't have any changes to recommend in this instance. 🎉
Reviewed with ❤️ by PullRequest
resolves #894
Fixes most console warnings, that appear when running the tests, reducing log lines from 4185 to just 160!
Material-UI: Thefadecolor utility was renamed toalphato better describe its functionality.cannot be straightforwardly resolved due to the outdated package@material-ui/pickerscausing it.Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()cannot be straightforwardly resolved due to the outdated packagesreact-leaflet,react-chartjsand@material-ui/pickers